From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: <paulz@synopsys.com>, <balbi@ti.com>, <dinh.linux@gmail.com>,
<linux-kernel@vger.kernel.org>, <swarren@wwwdotorg.org>,
<b.zolnierkie@samsung.com>, <matthijs@stdin.nl>,
<r.baldyga@samsung.com>, <jg1.han@samsung.com>,
<sachin.kamat@linaro.org>, <ben-linux@fluff.org>,
<dianders@chromium.org>, <kever.yang@rock-chips.com>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role
Date: Thu, 23 Oct 2014 10:05:43 -0500 [thread overview]
Message-ID: <54491947.4010008@opensource.altera.com> (raw)
In-Reply-To: <1414009627.17121.15.camel@x220>
On 10/22/2014 03:27 PM, Paul Bolle wrote:
> On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote:
>> On 10/20/2014 02:42 PM, Paul Bolle wrote:
>>> (Side note: drivers/usb/dwc2/Kconfig is sourced (in drivers/usb/Kconfig)
>>> even if USB is _not_ set. But USB_DCW2 still depends on USB. Why is
>>> that?)
>>
>> Because USB is for Host-Side support. DWC2 driver should only get built
>> for when USB is enabled. I think you're getting USB and USB_SUPPORT
>> mixed up.
>
> No, I don't think I did. Because in drivers/usb/Kconfig we see
> if USB
>
> [...]
>
> endif
>
> [...]
>
> source "drivers/usb/dwc2/Kconfig"
>
> [...]
Well, CONFIG_USB enables the host stack that is needed by the DWC2
driver, without CONFIG_USB, the DWC2 driver will not be able to build.
>
>> In addition, thanks to your comment, I realized that DWC2 should also be
>> available to build when USB_GADGET is enabled. A patch has been sent:
>>
>> http://marc.info/?l=linux-usb&m=141392377124818&w=2
>
> I haven't checked, but doesn't this mean USB_DWC2 could just depend on
> USB_SUPPORT?
>
I don't think so because USB_SUPPORT will not select USB or USB_GAGDGET,
and the DWC2 driver will need either 1 or both for it to build correctly.
Dinh
next prev parent reply other threads:[~2014-10-23 15:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 18:51 [PATCHv5 0/7] usb: dwc2: Add support for dual-role dinguyen
2014-10-20 18:52 ` [PATCHv5 1/7] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure dinguyen
2014-10-20 18:52 ` [PATCHv5 2/7] usb: dwc2: Move gadget probe function into platform code dinguyen
2014-10-22 11:16 ` Bartlomiej Zolnierkiewicz
2014-10-22 20:54 ` Paul Zimmerman
2014-10-23 19:08 ` Felipe Balbi
2014-10-20 18:52 ` [PATCHv5 3/7] usb: dwc2: Initialize the USB core for peripheral mode dinguyen
2014-10-20 18:52 ` [PATCHv5 4/7] usb: dwc2: Update common interrupt handler to call gadget interrupt handler dinguyen
2014-10-20 18:52 ` [PATCHv5 5/7] usb: dwc2: Add call_gadget functions for perpheral mode interrupts dinguyen
2014-10-20 18:52 ` [PATCHv5 6/7] usb: dwc2: gadget: Do not fail probe if there isn't a clock node dinguyen
2014-10-20 18:52 ` [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role dinguyen
2014-10-20 19:42 ` Paul Bolle
2014-10-21 20:47 ` Dinh Nguyen
2014-10-22 18:45 ` Paul Zimmerman
2014-10-22 20:27 ` Paul Bolle
2014-10-23 15:05 ` Dinh Nguyen [this message]
2014-10-23 17:10 ` Paul Bolle
2014-10-22 12:25 ` Bartlomiej Zolnierkiewicz
2014-10-22 12:29 ` Bartlomiej Zolnierkiewicz
2014-10-23 18:28 ` Paul Zimmerman
2014-10-23 18:26 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54491947.4010008@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=dianders@chromium.org \
--cc=dinh.linux@gmail.com \
--cc=jg1.han@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthijs@stdin.nl \
--cc=paulz@synopsys.com \
--cc=pebolle@tiscali.nl \
--cc=r.baldyga@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox