From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Paul Zimmerman <Paul.Zimmerman@synopsys.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
"dinh.linux@gmail.com" <dinh.linux@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"matthijs@stdin.nl" <matthijs@stdin.nl>,
"r.baldyga@samsung.com" <r.baldyga@samsung.com>,
"jg1.han@samsung.com" <jg1.han@samsung.com>,
"sachin.kamat@linaro.org" <sachin.kamat@linaro.org>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
"dianders@chromium.org" <dianders@chromium.org>,
"kever.yang@rock-chips.com" <kever.yang@rock-chips.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role
Date: Thu, 23 Oct 2014 13:26:41 -0500 [thread overview]
Message-ID: <54494861.80102@opensource.altera.com> (raw)
In-Reply-To: <A2CA0424C0A6F04399FB9E1CD98E0304844E54AC@US01WEMBX2.internal.synopsys.com>
On 10/23/2014 01:28 PM, Paul Zimmerman wrote:
>> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnierkie@samsung.com]
>> Sent: Wednesday, October 22, 2014 5:26 AM
>>
>> On Monday, October 20, 2014 01:52:06 PM dinguyen@opensource.altera.com wrote:
>>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>>
>>> config USB_DWC2_PLATFORM
>>> bool "DWC2 Platform"
>>> - depends on USB_DWC2_HOST
>>> default USB_DWC2_HOST
>>
>> It should be "default USB_DWC2_HOST || USB_DWC2_PERIPHERAL" because
>> USB_DWC2_PLATFORM replaces current USB_DWC2_PERIPHERAL functionality.
>>
>> Additionaly USB_DWC2_PLATFORM should be changed to tristate
>> (USB_DWC2_PERIPHERAL was a tristeate before your changes).
>
> Dinh, I think this is a good point. Is there any reason why
> USB_DWC2_PLATFORM (and USB_DWC2_PCI for that matter) can't be
> tristate? That's what DWC3 does.
>
Yes, in my v6, I have made this change.
Thanks,
Dinh
prev parent reply other threads:[~2014-10-23 18:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 18:51 [PATCHv5 0/7] usb: dwc2: Add support for dual-role dinguyen
2014-10-20 18:52 ` [PATCHv5 1/7] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure dinguyen
2014-10-20 18:52 ` [PATCHv5 2/7] usb: dwc2: Move gadget probe function into platform code dinguyen
2014-10-22 11:16 ` Bartlomiej Zolnierkiewicz
2014-10-22 20:54 ` Paul Zimmerman
2014-10-23 19:08 ` Felipe Balbi
2014-10-20 18:52 ` [PATCHv5 3/7] usb: dwc2: Initialize the USB core for peripheral mode dinguyen
2014-10-20 18:52 ` [PATCHv5 4/7] usb: dwc2: Update common interrupt handler to call gadget interrupt handler dinguyen
2014-10-20 18:52 ` [PATCHv5 5/7] usb: dwc2: Add call_gadget functions for perpheral mode interrupts dinguyen
2014-10-20 18:52 ` [PATCHv5 6/7] usb: dwc2: gadget: Do not fail probe if there isn't a clock node dinguyen
2014-10-20 18:52 ` [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role dinguyen
2014-10-20 19:42 ` Paul Bolle
2014-10-21 20:47 ` Dinh Nguyen
2014-10-22 18:45 ` Paul Zimmerman
2014-10-22 20:27 ` Paul Bolle
2014-10-23 15:05 ` Dinh Nguyen
2014-10-23 17:10 ` Paul Bolle
2014-10-22 12:25 ` Bartlomiej Zolnierkiewicz
2014-10-22 12:29 ` Bartlomiej Zolnierkiewicz
2014-10-23 18:28 ` Paul Zimmerman
2014-10-23 18:26 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54494861.80102@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=Paul.Zimmerman@synopsys.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=dianders@chromium.org \
--cc=dinh.linux@gmail.com \
--cc=jg1.han@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthijs@stdin.nl \
--cc=r.baldyga@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox