From: Bo Shen <voice.shen@atmel.com>
To: Peter Rosin <peda@axentia.se>
Cc: "'alsa-devel@alsa-project.org'" <alsa-devel@alsa-project.org>,
"Takashi Iwai" <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.
Date: Fri, 24 Oct 2014 16:43:13 +0800 [thread overview]
Message-ID: <544A1121.6080900@atmel.com> (raw)
In-Reply-To: <6496d69edfbf49ad81b068b259e98479@EMAIL.axentia.se>
Hi Peter,
On 10/24/2014 03:13 PM, Peter Rosin wrote:
>> Hi Peter,
>> Thanks for your patch.
>
> And thanks for the Ack!
>
>> Btw, do you use "git send-email" command to send the patch?
>
> No, I didn't, "git format-patch" and paste into the mail body. Was there some
> whitespace issues with the patch?
If you paste the patch in mail body, after apply your patch, git log
will show information look like:
--->8---
commit bfb9419839caeca07aa3e99c141fc7c1ac4f37af
Author: Peter Rosin <peda@axentia.se>
Date: Wed Oct 22 15:13:55 2014 +0000
ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.
From 86be84c4de4e7b21cfda9656a02a902c543210af Mon Sep 17 00:00:00 2001
From: Peter Rosin <peda@axentia.se>
Date: Wed, 22 Oct 2014 16:45:29 +0200
Subject: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only
in full
duplex.
The CMR divider register is shared by playback and capture. The SSC
driver
therefore tries to enforce rules so that the needed register content do
not conflict during simultaneous playback/capture. However, the
implementation also prevents changing the register content in
half-duplex scenarios, which is needed when using the OSS API.
---8<---
If you send patch use "git send-email", after apply your patch, git log
will show information look like
--->8---
commit bfb9419839caeca07aa3e99c141fc7c1ac4f37af
Author: Peter Rosin <peda@axentia.se>
Date: Wed Oct 22 15:13:55 2014 +0000
The CMR divider register is shared by playback and capture. The SSC
driver
therefore tries to enforce rules so that the needed register content do
not conflict during simultaneous playback/capture. However, the
implementation also prevents changing the register content in
half-duplex scenarios, which is needed when using the OSS API.
---8<---
> Cheers,
> Peter
>
Best Regards,
Bo Shen
next prev parent reply other threads:[~2014-10-24 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 15:13 [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex Peter Rosin
2014-10-24 3:15 ` Bo Shen
2014-10-24 7:13 ` Peter Rosin
2014-10-24 8:43 ` Bo Shen [this message]
2014-10-24 19:25 ` Peter Rosin
2014-10-24 19:25 ` [PATCH] " Peter Rosin
2014-10-31 18:12 ` Mark Brown
2014-11-03 1:25 ` Bo Shen
2014-11-03 12:45 ` Mark Brown
2014-10-24 8:46 ` [PATCH v2] " Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A1121.6080900@atmel.com \
--to=voice.shen@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox