From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbaJZP5U (ORCPT ); Sun, 26 Oct 2014 11:57:20 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:37649 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbaJZP5T (ORCPT ); Sun, 26 Oct 2014 11:57:19 -0400 Message-ID: <544D19DC.9050807@roeck-us.net> Date: Sun, 26 Oct 2014 08:57:16 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andrew Lunn , Florian Fainelli CC: netdev , "David S. Miller" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 06/14] net: dsa: Add support for hardware monitoring References: <20141023134706.GB25190@lunn.ch> <20141023162754.GA21343@roeck-us.net> <20141023165459.GE25190@lunn.ch> <20141023173847.GA22988@roeck-us.net> <20141023180357.GG25190@lunn.ch> <20141023184322.GA24281@roeck-us.net> <20141023195526.GH25190@lunn.ch> <20141024161919.GA29600@roeck-us.net> <20141025140116.GA12051@lunn.ch> <544BDC8F.2030308@gmail.com> <20141025180016.GA13191@lunn.ch> In-Reply-To: <20141025180016.GA13191@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020204.544D19DE.00EB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 1 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/2014 11:00 AM, Andrew Lunn wrote: > On Sat, Oct 25, 2014 at 10:23:27AM -0700, Florian Fainelli wrote: >> On 10/25/14 07:01, Andrew Lunn wrote: >>>> Here is another naming option: >>>> >>>> em1dsa0-virtual-0 >>> >>> I prefer this over isa. >>> >>> However, i think there should be some sort of separator between the >>> network device name and dsa. >> >> Considering that network devices can be renamed, do we want it to be >> included in the sensor name at all? > > Well, we need something which identifies the "DSA collection". In > that, you could have two or more collections, connected to different > network devices. > > I once came across a PCI board with two Intel ethernet chipsets and > two 10 port Marvell switches. Each switch had one host cpu port, 3 > ports interconnected to the other switch, and 6 going to the back > panel. You would want to describe that as two separate DSA entities, > not one DSA with two switches. So the name needs something to indicate > the DSA collection. > I agree. I could use the dsa instance index, so we would have names such as dsa0-isa-0000, dsa1-isa-0000, dsa0-isa-0001, dsa1-isa-0001, and so on, but that looks awkward (I can't do the index with virtual names because they don't have a parent and thus no index). Using the ethernet interface name seems like a good idea to me. Sure it can change, but the name is typically chosen before the dsa device is instantiated, and if it is changed manually later we just can not help it. So, if people want a delimiter between network device name and dsa, what should it be ? Unless I hear otherwise, I'll choose '_'. Guenter