Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs

Javier Martinez Canillas
2014-10-29T10:51:54Z

Hello Krzysztof,

On 10/29/2014 11:44 AM, Krzysztof Kozlowski wrote:
> On śro, 2014-10-29 at 10:31 +0000, Mark Brown wrote:
>> On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote:
>> > On śro, 2014-10-29 at 10:01 +0000, Mark Brown wrote:
>>
>> > > No, this isn't suspend enable control - this is normal, standard enable
>> > > control and the device has no suspend enable control.
>>
>> > You mean that for such regulator the driver shouldn't implement
>> > suspend_enable()?
>>
>> Yes, if there is no separate control of suspend mode in hardware then of
>> course the driver shouldn't implement operations for things it doesn't
>> have.
>
> Oh, thanks! I'll send fixed patch.
>
> This means that probably the max77802 ("mirrored" driver) should be
> fixed...
>

Indeed, I had the same confusion that you had. Just to avoid duplicating work,
do you want me to send a fix or are you going to include one on your series?

> Best regards,
> Krzysztof
>
>

Best regards,
Javier