From: Stephen Warren <swarren@wwwdotorg.org>
To: Matthias Klein <matthias.klein@linux.com>,
linux-rpi-kernel@lists.infradead.org, linus.walleij@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: bcm2835: Start GPIO numeration at zero
Date: Mon, 27 Oct 2014 16:44:02 -0600 [thread overview]
Message-ID: <544ECAB2.3060706@wwwdotorg.org> (raw)
In-Reply-To: <1414447799-1284-1-git-send-email-matthias.klein@linux.com>
On 10/27/2014 04:09 PM, Matthias Klein wrote:
> Numerate the GPIOs from 0..53 instead of 202..255.
What's the motivation for this? The GPIO IDs should all come from DT,
which encodes everything as an ID relative to a particular controllers,
and hence the actual value of the base address should be irrelevant.
> diff --git a/drivers/pinctrl/pinctrl-bcm2835.c b/drivers/pinctrl/pinctrl-bcm2835.c
> @@ -382,7 +382,7 @@ static struct gpio_chip bcm2835_gpio_chip = {
> - .base = -1,
> + .base = 0,
next prev parent reply other threads:[~2014-10-27 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 22:09 [PATCH v2] pinctrl: bcm2835: Start GPIO numeration at zero Matthias Klein
2014-10-27 22:44 ` Stephen Warren [this message]
2014-10-27 23:05 ` Matthias Klein
2014-10-28 0:00 ` Stephen Warren
2014-10-28 7:10 ` Matthias Klein
[not found] ` <544F3FDA.60407@linux.com>
2014-10-29 1:15 ` Stephen Warren
2014-10-31 9:49 ` Linus Walleij
2014-11-01 6:13 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544ECAB2.3060706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=matthias.klein@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox