From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xensource.com>, <konrad.wilk@oracle.com>,
<boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 2/2] Xen: switch to linear virtual mapped sparse p2m list
Date: Tue, 28 Oct 2014 17:55:52 +0000 [thread overview]
Message-ID: <544FD8A8.4060709@citrix.com> (raw)
In-Reply-To: <1414421551-31555-3-git-send-email-jgross@suse.com>
On 27/10/14 14:52, Juergen Gross wrote:
> At start of the day the Xen hypervisor presents a contiguous mfn list
> to a pv-domain. In order to support sparse memory this mfn list is
> accessed via a three level p2m tree built early in the boot process.
> Whenever the system needs the mfn associated with a pfn this tree is
> used to find the mfn.
>
> Instead of using a software walked tree for accessing a specific mfn
> list entry this patch is creating a virtual address area for the
> entire possible mfn list including memory holes. The holes are
> covered by mapping a pre-defined page consisting only of "invalid
> mfn" entries. Access to a mfn entry is possible by just using the
> virtual base address of the mfn list and the pfn as index into that
> list. This speeds up the (hot) path of determining the mfn of a
> pfn.
I'm generally in favour of this I think but this is just too big to
review carefully. Is there any way you can split this up? Perhaps with
some preparatory patches before the big switch to the linear array?
David
next prev parent reply other threads:[~2014-10-28 17:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 14:52 [PATCH 0/2] xen: Switch to virtual mapped linear p2m list Juergen Gross
2014-10-27 14:52 ` [PATCH 1/2] Xen: Delay remapping memory of pv-domain Juergen Gross
2014-10-28 17:34 ` David Vrabel
2014-10-29 5:30 ` Juergen Gross
2014-10-29 5:43 ` Juergen Gross
2014-10-27 14:52 ` [PATCH 2/2] Xen: switch to linear virtual mapped sparse p2m list Juergen Gross
2014-10-28 17:55 ` David Vrabel [this message]
2014-10-27 15:16 ` [PATCH 0/2] xen: Switch to virtual mapped linear " David Vrabel
2014-10-28 5:00 ` Juergen Gross
2014-10-28 9:51 ` [Xen-devel] " Ian Campbell
2014-10-28 11:53 ` Andrew Cooper
2014-10-28 12:07 ` Juergen Gross
2014-10-28 12:39 ` David Vrabel
2014-10-28 12:42 ` Andrew Cooper
2014-10-28 12:44 ` David Vrabel
2014-10-28 12:46 ` Andrew Cooper
2014-10-28 13:03 ` Juergen Gross
2014-10-28 13:04 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FD8A8.4060709@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox