public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: at91: fix compilation
@ 2014-10-28 18:58 Alexandre Belloni
  2014-10-28 19:10 ` Sergei Shtylyov
  2014-10-29  8:30 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Alexandre Belloni @ 2014-10-28 18:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Nicolas Ferre, Jean-Christophe Plagniol-Villard, Boris Brezillon,
	linux-kernel, linux-arm-kernel, Alexandre Belloni

Add macros introduced by 4334ac2db2be9e278c95fd15260c1f49f698ffc5 that
were missed when copying the header.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/pinctrl/pinctrl-at91.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-at91.h b/drivers/pinctrl/pinctrl-at91.h
index c837c66ea360..79b957f1dfa2 100644
--- a/drivers/pinctrl/pinctrl-at91.h
+++ b/drivers/pinctrl/pinctrl-at91.h
@@ -63,4 +63,10 @@
 #define PIO_FRLHSR	0xd8	/* Fall/Rise - Low/High Status Register */
 #define PIO_SCHMITT	0x100	/* Schmitt Trigger Register */
 
+#define SAMA5D3_PIO_DRIVER1		0x118  /*PIO Driver 1 register offset*/
+#define SAMA5D3_PIO_DRIVER2		0x11C  /*PIO Driver 2 register offset*/
+
+#define AT91SAM9X5_PIO_DRIVER1	0x114  /*PIO Driver 1 register offset*/
+#define AT91SAM9X5_PIO_DRIVER2	0x118  /*PIO Driver 2 register offset*/
+
 #endif
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: at91: fix compilation
  2014-10-28 18:58 [PATCH] pinctrl: at91: fix compilation Alexandre Belloni
@ 2014-10-28 19:10 ` Sergei Shtylyov
  2014-10-29  8:30 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2014-10-28 19:10 UTC (permalink / raw)
  To: Alexandre Belloni, Linus Walleij
  Cc: Boris Brezillon, Nicolas Ferre, linux-kernel,
	Jean-Christophe Plagniol-Villard, linux-arm-kernel

Hello.

On 10/28/2014 09:58 PM, Alexandre Belloni wrote:

> Add macros introduced by 4334ac2db2be9e278c95fd15260c1f49f698ffc5 that

    Please also specify that commit's summary line in parens.

> were missed when copying the header.

> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>   drivers/pinctrl/pinctrl-at91.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.h b/drivers/pinctrl/pinctrl-at91.h
> index c837c66ea360..79b957f1dfa2 100644
> --- a/drivers/pinctrl/pinctrl-at91.h
> +++ b/drivers/pinctrl/pinctrl-at91.h
> @@ -63,4 +63,10 @@
>   #define PIO_FRLHSR	0xd8	/* Fall/Rise - Low/High Status Register */
>   #define PIO_SCHMITT	0x100	/* Schmitt Trigger Register */
>
> +#define SAMA5D3_PIO_DRIVER1		0x118  /*PIO Driver 1 register offset*/
> +#define SAMA5D3_PIO_DRIVER2		0x11C  /*PIO Driver 2 register offset*/
> +
> +#define AT91SAM9X5_PIO_DRIVER1	0x114  /*PIO Driver 1 register offset*/
> +#define AT91SAM9X5_PIO_DRIVER2	0x118  /*PIO Driver 2 register offset*/

    Please add spaces after /* and before */.

WBR, Sergei


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: at91: fix compilation
  2014-10-28 18:58 [PATCH] pinctrl: at91: fix compilation Alexandre Belloni
  2014-10-28 19:10 ` Sergei Shtylyov
@ 2014-10-29  8:30 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-10-29  8:30 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Nicolas Ferre, Jean-Christophe Plagniol-Villard, Boris Brezillon,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org

On Tue, Oct 28, 2014 at 7:58 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:

> Add macros introduced by 4334ac2db2be9e278c95fd15260c1f49f698ffc5 that
> were missed when copying the header.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

I squashed this into the offending commit.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-29  8:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28 18:58 [PATCH] pinctrl: at91: fix compilation Alexandre Belloni
2014-10-28 19:10 ` Sergei Shtylyov
2014-10-29  8:30 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox