public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: skein: skein_api.c: removed space before ','
@ 2014-10-27 22:17 Mikael Svantesson
  2014-10-28  6:50 ` Dan Carpenter
  0 siblings, 1 reply; 6+ messages in thread
From: Mikael Svantesson @ 2014-10-27 22:17 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jason Cooper, Jake Edge, Anton Saraev, devel
  Cc: Mikael Svantesson, linux-kernel

Signed-off-by: Mikael Svantesson <mikael@distopic.net>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/skein/skein_api.c
b/drivers/staging/skein/skein_api.c
index 6e700ee..5bfce07 100644
--- a/drivers/staging/skein/skein_api.c
+++ b/drivers/staging/skein/skein_api.c
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum
skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] staging: skein: skein_api.c: removed space before ','
  2014-10-27 22:17 [PATCH] staging: skein: skein_api.c: removed space before ',' Mikael Svantesson
@ 2014-10-28  6:50 ` Dan Carpenter
  2014-10-28 19:59   ` Mikael Svantesson
  0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2014-10-28  6:50 UTC (permalink / raw)
  To: Mikael Svantesson
  Cc: Greg Kroah-Hartman, Jason Cooper, Jake Edge, Anton Saraev, devel,
	linux-kernel

On Mon, Oct 27, 2014 at 11:17:02PM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>

The patch is corrupt (and in a totally weird way as well).  Please read
the first paragraph for Documentation/email-clients.txt.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] staging: skein: skein_api.c: removed space before ','
  2014-10-28  6:50 ` Dan Carpenter
@ 2014-10-28 19:59   ` Mikael Svantesson
  0 siblings, 0 replies; 6+ messages in thread
From: Mikael Svantesson @ 2014-10-28 19:59 UTC (permalink / raw)
  To: Dan Carpenter, Mikael Svantesson
  Cc: Greg Kroah-Hartman, Jason Cooper, Jake Edge, Anton Saraev, devel,
	linux-kernel

On 2014-10-28 07:50, Dan Carpenter wrote:
> On Mon, Oct 27, 2014 at 11:17:02PM +0100, Mikael Svantesson wrote:
>> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> 
> The patch is corrupt (and in a totally weird way as well).  Please read
> the first paragraph for Documentation/email-clients.txt.
> 
> regards,
> dan carpenter
> 
After all checking and making sure things looked correct, I still failed
to disable word wrapping.

Thanks, I'll resubmit a working patch.

Regards,
Mikael

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] staging: skein: skein_api.c: removed space before ','
  2014-10-29 16:38 [PATCH v2] " Mikael Svantesson
@ 2014-10-29 17:45 ` Mikael Svantesson
  2014-10-30  5:45   ` Sudip Mukherjee
  0 siblings, 1 reply; 6+ messages in thread
From: Mikael Svantesson @ 2014-10-29 17:45 UTC (permalink / raw)
  To: mikael; +Cc: linux-kernel

Signed-off-by: Mikael Svantesson <mikael@distopic.net>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
index 6e700ee..5bfce07 100644
--- a/drivers/staging/skein/skein_api.c
+++ b/drivers/staging/skein/skein_api.c
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 
-	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
 
 	return SKEIN_SUCCESS;
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] staging: skein: skein_api.c: removed space before ','
       [not found] ` <1414601738-11968-1-git-send-email-mikael@distopic.net>
@ 2014-10-29 17:51   ` Jason Cooper
  0 siblings, 0 replies; 6+ messages in thread
From: Jason Cooper @ 2014-10-29 17:51 UTC (permalink / raw)
  To: Mikael Svantesson
  Cc: Greg Kroah-Hartman, Jake Edge, Anton Saraev, devel, linux-kernel

Mikael,

On Wed, Oct 29, 2014 at 05:55:34PM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> ---
>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

For future patches, please remember to add the 'V3' to the subject like
you did for v2.

thx,

Jason.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] staging: skein: skein_api.c: removed space before ','
  2014-10-29 17:45 ` [PATCH] " Mikael Svantesson
@ 2014-10-30  5:45   ` Sudip Mukherjee
  0 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2014-10-30  5:45 UTC (permalink / raw)
  To: Mikael Svantesson; +Cc: linux-kernel

On Wed, Oct 29, 2014 at 06:45:14PM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> ---
better to send this as a new thread and start the subject
as [PATCH v3]
and also mention a commit message.

thanks
sudip

>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> index 6e700ee..5bfce07 100644
> --- a/drivers/staging/skein/skein_api.c
> +++ b/drivers/staging/skein/skein_api.c
> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>  {
>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>  
> -	memset(ctx , 0, sizeof(struct skein_ctx));
> +	memset(ctx, 0, sizeof(struct skein_ctx));
>  	ctx->skein_size = size;
>  
>  	return SKEIN_SUCCESS;
> -- 
> 2.1.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-10-30  5:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-27 22:17 [PATCH] staging: skein: skein_api.c: removed space before ',' Mikael Svantesson
2014-10-28  6:50 ` Dan Carpenter
2014-10-28 19:59   ` Mikael Svantesson
  -- strict thread matches above, loose matches on Subject: below --
2014-10-29 15:56 [PATCH v2] " Mikael Svantesson
     [not found] ` <1414601738-11968-1-git-send-email-mikael@distopic.net>
2014-10-29 17:51   ` [PATCH] " Jason Cooper
2014-10-29 16:38 [PATCH v2] " Mikael Svantesson
2014-10-29 17:45 ` [PATCH] " Mikael Svantesson
2014-10-30  5:45   ` Sudip Mukherjee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox