[PATCH v2] staging: skein: skein_api.c: removed space before ','

[PATCH v2] staging: skein: skein_api.c: removed space before ','

[Mikael Svantesson]

Signed-off-by: Mikael Svantesson <mikael@distopic.net>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
index 6e700ee..5bfce07 100644
--- a/drivers/staging/skein/skein_api.c
+++ b/drivers/staging/skein/skein_api.c
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 -	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
  	return SKEIN_SUCCESS;
-- 
2.1.1

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Sudip Mukherjee]

On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
still the same problem.

ERROR: patch seems to be corrupt (line wrapped?)


> ---
>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> index 6e700ee..5bfce07 100644
> --- a/drivers/staging/skein/skein_api.c
> +++ b/drivers/staging/skein/skein_api.c
> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>  {
>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>  -	memset(ctx , 0, sizeof(struct skein_ctx));
> +	memset(ctx, 0, sizeof(struct skein_ctx));
>  	ctx->skein_size = size;
>   	return SKEIN_SUCCESS;
> -- 
> 2.1.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Mikael Svantesson]

I'm saving the patch to my mail server using git-imap-send, then enter
e-mail addresses using Thunderbird and send it.

The problem seems to be that Thunderbird thrashes empty lines when
double clicking the e-mail in Drafts or selecting "Edit as new".
When forwarding the e-mail it doesn't seem to affect the empty lines,
very weird behaviour.

Regards,

Mikael

On 2014-10-29 06:25, Sudip Mukherjee wrote:
> On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
>> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> still the same problem.
> 
> ERROR: patch seems to be corrupt (line wrapped?)
> 
> 
>> ---
>>  drivers/staging/skein/skein_api.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
>> index 6e700ee..5bfce07 100644
>> --- a/drivers/staging/skein/skein_api.c
>> +++ b/drivers/staging/skein/skein_api.c
>> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>>  {
>>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>>  -	memset(ctx , 0, sizeof(struct skein_ctx));
>> +	memset(ctx, 0, sizeof(struct skein_ctx));
>>  	ctx->skein_size = size;
>>   	return SKEIN_SUCCESS;
>> -- 
>> 2.1.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Mikael Svantesson]

Signed-off-by: Mikael Svantesson <mikael@distopic.net>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
index 6e700ee..5bfce07 100644
--- a/drivers/staging/skein/skein_api.c
+++ b/drivers/staging/skein/skein_api.c
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 
-	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
 
 	return SKEIN_SUCCESS;
-- 
2.1.1

On 2014-10-29 08:15, Mikael Svantesson wrote:
> I'm saving the patch to my mail server using git-imap-send, then enter
> e-mail addresses using Thunderbird and send it.
> 
> The problem seems to be that Thunderbird thrashes empty lines when
> double clicking the e-mail in Drafts or selecting "Edit as new".
> When forwarding the e-mail it doesn't seem to affect the empty lines,
> very weird behaviour.
> 
> Regards,
> 
> Mikael
> 
> On 2014-10-29 06:25, Sudip Mukherjee wrote:
>> On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
>>> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
>> still the same problem.
>>
>> ERROR: patch seems to be corrupt (line wrapped?)
>>
>>
>>> ---
>>>  drivers/staging/skein/skein_api.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
>>> index 6e700ee..5bfce07 100644
>>> --- a/drivers/staging/skein/skein_api.c
>>> +++ b/drivers/staging/skein/skein_api.c
>>> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>>>  {
>>>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>>>  -	memset(ctx , 0, sizeof(struct skein_ctx));
>>> +	memset(ctx, 0, sizeof(struct skein_ctx));
>>>  	ctx->skein_size = size;
>>>   	return SKEIN_SUCCESS;
>>> -- 
>>> 2.1.1
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Sudip Mukherjee]

On Wed, Oct 29, 2014 at 08:15:43AM +0100, Mikael Svantesson wrote:
> I'm saving the patch to my mail server using git-imap-send, then enter
> e-mail addresses using Thunderbird and send it.
any particular reason that you are not sending it using git send-email ?

> 
> The problem seems to be that Thunderbird thrashes empty lines when
> double clicking the e-mail in Drafts or selecting "Edit as new".
> When forwarding the e-mail it doesn't seem to affect the empty lines,
> very weird behaviour.
> 
> Regards,
> 
> Mikael
> 
> On 2014-10-29 06:25, Sudip Mukherjee wrote:
> > On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
> >> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> > still the same problem.
> > 
> > ERROR: patch seems to be corrupt (line wrapped?)
> > 
> > 
> >> ---
> >>  drivers/staging/skein/skein_api.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> >> index 6e700ee..5bfce07 100644
> >> --- a/drivers/staging/skein/skein_api.c
> >> +++ b/drivers/staging/skein/skein_api.c
> >> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
> >>  {
> >>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
> >>  -	memset(ctx , 0, sizeof(struct skein_ctx));
> >> +	memset(ctx, 0, sizeof(struct skein_ctx));
> >>  	ctx->skein_size = size;
> >>   	return SKEIN_SUCCESS;
> >> -- 
> >> 2.1.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Greg Kroah-Hartman]

On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> ---
>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> index 6e700ee..5bfce07 100644
> --- a/drivers/staging/skein/skein_api.c
> +++ b/drivers/staging/skein/skein_api.c
> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>  {
>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>  -	memset(ctx , 0, sizeof(struct skein_ctx));
> +	memset(ctx, 0, sizeof(struct skein_ctx));

Still corrupted, what added the extra ' ' before the '-'?

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Mikael Svantesson]

On 2014-10-29 09:41, Greg Kroah-Hartman wrote:
> On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
>> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
>> ---
>>  drivers/staging/skein/skein_api.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
>> index 6e700ee..5bfce07 100644
>> --- a/drivers/staging/skein/skein_api.c
>> +++ b/drivers/staging/skein/skein_api.c
>> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>>  {
>>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>>  -	memset(ctx , 0, sizeof(struct skein_ctx));
>> +	memset(ctx, 0, sizeof(struct skein_ctx));
> 
> Still corrupted, what added the extra ' ' before the '-'?
> 
Thunderbird builtin editor, I guess. Can't remember why I decided to do
it that way instead of git-send-email.

I replied to my other explanation with a non-corrupt patch but I can
submit it as v3 instead if that's preferable.

/ Mikael

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Greg Kroah-Hartman]

On Wed, Oct 29, 2014 at 08:25:30AM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> ---
>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> index 6e700ee..5bfce07 100644
> --- a/drivers/staging/skein/skein_api.c
> +++ b/drivers/staging/skein/skein_api.c
> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>  {
>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>  
> -	memset(ctx , 0, sizeof(struct skein_ctx));
> +	memset(ctx, 0, sizeof(struct skein_ctx));
>  	ctx->skein_size = size;
>  
>  	return SKEIN_SUCCESS;
> -- 
> 2.1.1
> 
> On 2014-10-29 08:15, Mikael Svantesson wrote:
> > I'm saving the patch to my mail server using git-imap-send, then enter
> > e-mail addresses using Thunderbird and send it.
> > 
> > The problem seems to be that Thunderbird thrashes empty lines when
> > double clicking the e-mail in Drafts or selecting "Edit as new".
> > When forwarding the e-mail it doesn't seem to affect the empty lines,
> > very weird behaviour.
> > 
> > Regards,
> > 
> > Mikael
> > 
> > On 2014-10-29 06:25, Sudip Mukherjee wrote:
> >> On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
> >>> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> >> still the same problem.
> >>
> >> ERROR: patch seems to be corrupt (line wrapped?)
> >>
> >>
> >>> ---
> >>>  drivers/staging/skein/skein_api.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> >>> index 6e700ee..5bfce07 100644
> >>> --- a/drivers/staging/skein/skein_api.c
> >>> +++ b/drivers/staging/skein/skein_api.c
> >>> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
> >>>  {
> >>>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
> >>>  -	memset(ctx , 0, sizeof(struct skein_ctx));
> >>> +	memset(ctx, 0, sizeof(struct skein_ctx));
> >>>  	ctx->skein_size = size;
> >>>   	return SKEIN_SUCCESS;
> >>> -- 
> >>> 2.1.1
> >>>
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >>> the body of a message to majordomo@vger.kernel.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>> Please read the FAQ at  http://www.tux.org/lkml/
> > 

Please send this as a "correct" patch, not one with a whole bunch of
other stuff in it that I would have to hand-edit in order to apply
properly.

Remember, you want to make it as easy as possible for me to accept your
patches, so far, this isn't going well :)

greg k-h

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

[Mikael Svantesson]

On 2014-10-29 17:05, Greg Kroah-Hartman wrote:
> Please send this as a "correct" patch, not one with a whole bunch of
> other stuff in it that I would have to hand-edit in order to apply
> properly.
> 
> Remember, you want to make it as easy as possible for me to accept your
> patches, so far, this isn't going well :)
> 
> greg k-h
> 

Yeah, sorry about that. I have no idea why I haven't just used
git-send-email.

I'll reply to this e-mail with a (hopefully) correct e-mail, otherwise
I'll just give up, this is starting to get too embarassing. :D

/ Mikael

[PATCH] staging: skein: skein_api.c: removed space before ','

[Mikael Svantesson]

Signed-off-by: Mikael Svantesson <mikael@distopic.net>
---
 drivers/staging/skein/skein_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
index 6e700ee..5bfce07 100644
--- a/drivers/staging/skein/skein_api.c
+++ b/drivers/staging/skein/skein_api.c
@@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
 {
 	skein_assert_ret(ctx && size, SKEIN_FAIL);
 
-	memset(ctx , 0, sizeof(struct skein_ctx));
+	memset(ctx, 0, sizeof(struct skein_ctx));
 	ctx->skein_size = size;
 
 	return SKEIN_SUCCESS;
-- 
2.1.1

Re: [PATCH] staging: skein: skein_api.c: removed space before ','

[Jason Cooper]

Mikael,

On Wed, Oct 29, 2014 at 05:55:34PM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> ---
>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

For future patches, please remember to add the 'V3' to the subject like
you did for v2.

thx,

Jason.

Re: [PATCH] staging: skein: skein_api.c: removed space before ','

[Sudip Mukherjee]

On Wed, Oct 29, 2014 at 06:45:14PM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@distopic.net>
> ---
better to send this as a new thread and start the subject
as [PATCH v3]
and also mention a commit message.

thanks
sudip

>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> index 6e700ee..5bfce07 100644
> --- a/drivers/staging/skein/skein_api.c
> +++ b/drivers/staging/skein/skein_api.c
> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>  {
>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>  
> -	memset(ctx , 0, sizeof(struct skein_ctx));
> +	memset(ctx, 0, sizeof(struct skein_ctx));
>  	ctx->skein_size = size;
>  
>  	return SKEIN_SUCCESS;
> -- 
> 2.1.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/