Re: [PATCH 1/2] UBI: Implement UBI_METAONLY

[Richard Weinberger <richard@nod.at>]

Am 29.10.2014 um 21:11 schrieb Andrew Murray:
> On 29 October 2014 14:52, Richard Weinberger <richard@nod.at> wrote:
>> diff --git a/include/linux/mtd/ubi.h b/include/linux/mtd/ubi.h
>> index c3918a0..82b693f 100644
>> --- a/include/linux/mtd/ubi.h
>> +++ b/include/linux/mtd/ubi.h
>> @@ -34,11 +34,13 @@
>>   * UBI_READONLY: read-only mode
>>   * UBI_READWRITE: read-write mode
>>   * UBI_EXCLUSIVE: exclusive mode
>> + * UBI_METAONLY: modify voulme meta data only
> 
> Typo - s/voulme/volume/g

Thanks. :)

>>   */
>>  enum {
>>         UBI_READONLY = 1,
>>         UBI_READWRITE,
>> -       UBI_EXCLUSIVE
>> +       UBI_EXCLUSIVE,
>> +       UBI_METAONLY
>>  };
>>
> 
> Also you may want to add something similar to this:
> 
> --- a/drivers/mtd/ubi/ubi.h
> +++ b/drivers/mtd/ubi/ubi.h
> @@ -339,7 +339,7 @@ struct ubi_volume {
>  /**
>   * struct ubi_volume_desc - UBI volume descriptor returned when it is opened.
>   * @vol: reference to the corresponding volume description object
> - * @mode: open mode (%UBI_READONLY, %UBI_READWRITE, or %UBI_EXCLUSIVE)
> + * @mode: open mode (%UBI_READONLY, %UBI_READWRITE, %UBI_EXCLUSIVE or
> %UBI_METAONLY)
>   */
>  struct ubi_volume_desc {
>         struct ubi_volume *vol;
> 
> There is also a similar mention in gluebi.c: 'readers/writes/exclusive'.

Please send a patch for that. :)

Thanks,
//richard