Re: [PATCH 6/6] sched/dl: don't check CONFIG_SMP in switched_from_dl

Juri Lelli
2014-10-30T10:29:52Z

Hi,

On 27/10/14 01:41, Wanpeng Li wrote:
> There are both UP and SMP version of pull_dl_task(), so don't need
> to check CONFIG_SMP in switched_from_dl();
>
> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
> ---
> kernel/sched/deadline.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 21de865..35d6dd5 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1577,7 +1577,6 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p)
>
> __dl_clear_params(p);
>
> -#ifdef CONFIG_SMP
> /*
> * Since this might be the only -deadline task on the rq,
> * this is the right place to try to pull some other one
> @@ -1585,7 +1584,6 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p)
> */
> if (!rq->dl.dl_nr_running && pull_dl_task(rq))
> resched_curr(rq);
> -#endif
> }
>
> /*
>

Yes, we can remove it.

Thanks,

- Juri