From: Markos Chandras <Markos.Chandras@imgtec.com>
To: James Hogan <james.hogan@imgtec.com>,
Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>,
<linux-mips@linux-mips.org>, <nbd@openwrt.org>, <yanh@lemote.com>,
<linux-kernel@vger.kernel.org>, <ralf@linux-mips.org>,
<alex.smith@imgtec.com>, <taohl@lemote.com>, <chenhc@lemote.com>,
<blogic@openwrt.org>
Subject: Re: [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems
Date: Thu, 30 Oct 2014 09:54:04 +0000 [thread overview]
Message-ID: <54520ABC.3040305@imgtec.com> (raw)
In-Reply-To: <54520A2D.5080304@imgtec.com>
On 10/30/2014 09:51 AM, James Hogan wrote:
> Hi Markos,
>
> On 30/10/14 09:48, Markos Chandras wrote:
>>> diff --git a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h
>>> index f9f4486..fe0b465 100644
>>> --- a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h
>>> +++ b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h
>>> @@ -52,7 +52,7 @@ static inline int plat_dma_supported(struct device *dev, u64 mask)
>>> return 0;
>>> }
>>>
>>> -static inline int plat_device_is_coherent(struct device *dev)
>>> +static inline int plat_device_is_coherent(const struct device *dev)
>>
>> Why adding const here?
>>
>
> <snip>
>
>> Is it just a matter of consistence with the rest of the interfaces? Do
>> you need to move these into a separate patch since they don't quite fit
>> here.
>
> See the new new call to plat_device_is_coherent(), which passes dev,
> which is const.
>
> Cheers
> James
>
Ah yes you are right. Thanks!
--
markos
next prev parent reply other threads:[~2014-10-30 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 1:48 [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems Leonid Yegoshin
2014-10-30 9:48 ` Markos Chandras
2014-10-30 9:51 ` James Hogan
2014-10-30 9:54 ` Markos Chandras [this message]
2014-10-30 10:07 ` James Hogan
2014-10-30 18:38 ` Leonid Yegoshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54520ABC.3040305@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=alex.smith@imgtec.com \
--cc=blogic@openwrt.org \
--cc=chenhc@lemote.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=nbd@openwrt.org \
--cc=ralf@linux-mips.org \
--cc=taohl@lemote.com \
--cc=yanh@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox