Re: [PATCH 2/2] hwmon: (ibmpowernv) Make the driver name more recognisable

Jean Delvare
2014-10-31T08:35:36Z

Hi Michael,

On Fri, 31 Oct 2014 17:45:23 +1100, Michael Ellerman wrote:
> Seeing "ibmpowernv" in dmesg is not very useful, that is just the name
> of the platform and doesn't identify the message as coming from the
> hwmon driver.
>
> Change DRVNAME to "powernv-hwmon" to make it clearer.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> drivers/hwmon/ibmpowernv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
> index 6a30eeea94be..3ee00928cda9 100644
> --- a/drivers/hwmon/ibmpowernv.c
> +++ b/drivers/hwmon/ibmpowernv.c
> @@ -16,7 +16,7 @@
> * along with this program.
> */
>
> -#define DRVNAME "ibmpowernv"
> +#define DRVNAME "powernv-hwmon"
> #define pr_fmt(fmt) DRVNAME ": " fmt
>
> #include <linux/init.h>

Nack. For one thing, DRVNAME is used for
devm_hwmon_device_register_with_groups and dashes are not allowed in
the name attribute. For another, making the driver name different from
the module name makes things more confusing, not clearer.

Like it or not, almost no hwmon driver has hwmon in its name anyway.

--
Jean Delvare
SUSE L3 Support