From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: cmetcalf@tilera.com, dwalter@google.com, richard@nod.at,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch: tile: kernel: signal.c: Use explicitly type case "unsigned long *" for register copy
Date: Sun, 02 Nov 2014 10:02:14 +0800 [thread overview]
Message-ID: <545590A6.2040407@gmail.com> (raw)
In-Reply-To: <20141101202350.GS7996@ZenIV.linux.org.uk>
On 11/2/14 4:23, Al Viro wrote:
> On Sat, Nov 01, 2014 at 08:49:45PM +0800, Chen Gang wrote:
>> setup_sigcontext() wants to copy all kernel related registers to user
>> space. So let it copy explicitly instead of copying by exceeding member
>> array border. So let code more clearer and avoid warning.
>
> Er... Perhaps it would be better to avoid that shite completely and just
> use __copy_to_user() instead of bothering with loops?
>
OK, thanks, I shall send patch v2 for it.
Also use __copy_from_user() instead of the code in restore_sigcontext().
Thanks
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
prev parent reply other threads:[~2014-11-02 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 12:49 [PATCH] arch: tile: kernel: signal.c: Use explicitly type case "unsigned long *" for register copy Chen Gang
2014-11-01 20:23 ` Al Viro
2014-11-02 2:02 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545590A6.2040407@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=cmetcalf@tilera.com \
--cc=dwalter@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox