* [PATCH] usb: option: Add ID for Peiker LTE NAD @ 2014-11-01 16:01 Matthias Klein 2014-11-02 3:35 ` Lars Melin 0 siblings, 1 reply; 4+ messages in thread From: Matthias Klein @ 2014-11-01 16:01 UTC (permalink / raw) To: johan, linux-usb, linux-kernel Add ID of the Peiker LTE NAD for legacy serial interface Signed-off-by: Matthias Klein <matthias.klein@linux.com> --- drivers/usb/serial/option.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d1a3f60..d7f1042 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */ { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) }, { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) }, { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003), -- 2.1.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: option: Add ID for Peiker LTE NAD 2014-11-01 16:01 [PATCH] usb: option: Add ID for Peiker LTE NAD Matthias Klein @ 2014-11-02 3:35 ` Lars Melin 2014-11-02 15:31 ` Matthias Klein 0 siblings, 1 reply; 4+ messages in thread From: Lars Melin @ 2014-11-02 3:35 UTC (permalink / raw) To: Matthias Klein, johan, linux-usb, linux-kernel On 2014-11-01 23:01, Matthias Klein wrote: > Add ID of the Peiker LTE NAD for legacy serial interface > > Signed-off-by: Matthias Klein <matthias.klein@linux.com> > --- > drivers/usb/serial/option.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index d1a3f60..d7f1042 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ > { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ > { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ > + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */ > { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) }, > { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) }, > { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003), 05c6:9025 already has its net interface (#4) supported by the qmi_wwan driver so your patch is wrong. There is also an ADB interface which I don't think should be driven by option. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: option: Add ID for Peiker LTE NAD 2014-11-02 3:35 ` Lars Melin @ 2014-11-02 15:31 ` Matthias Klein 2014-11-04 12:40 ` Bjørn Mork 0 siblings, 1 reply; 4+ messages in thread From: Matthias Klein @ 2014-11-02 15:31 UTC (permalink / raw) To: Lars Melin, johan, linux-usb, linux-kernel Am 02.11.2014 um 04:35 schrieb Lars Melin: > On 2014-11-01 23:01, Matthias Klein wrote: >> Add ID of the Peiker LTE NAD for legacy serial interface >> >> Signed-off-by: Matthias Klein <matthias.klein@linux.com> >> --- >> drivers/usb/serial/option.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >> index d1a3f60..d7f1042 100644 >> --- a/drivers/usb/serial/option.c >> +++ b/drivers/usb/serial/option.c >> @@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = { >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE >> MF330 */ >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ >> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */ >> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) }, >> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) }, >> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003), > 05c6:9025 already has its net interface (#4) supported by the qmi_wwan > driver so your patch is wrong. > There is also an ADB interface which I don't think should be driven by > option. > > The ID is right, and it can be used with the option driver or qmi_wwan. Ignore my patch, I will move to qmi_wwan in the future ... ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: option: Add ID for Peiker LTE NAD 2014-11-02 15:31 ` Matthias Klein @ 2014-11-04 12:40 ` Bjørn Mork 0 siblings, 0 replies; 4+ messages in thread From: Bjørn Mork @ 2014-11-04 12:40 UTC (permalink / raw) To: Matthias Klein; +Cc: Lars Melin, johan, linux-usb, linux-kernel Matthias Klein <matthias.klein@linux.com> writes: > Am 02.11.2014 um 04:35 schrieb Lars Melin: >> On 2014-11-01 23:01, Matthias Klein wrote: >>> Add ID of the Peiker LTE NAD for legacy serial interface >>> >>> Signed-off-by: Matthias Klein <matthias.klein@linux.com> >>> --- >>> drivers/usb/serial/option.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >>> index d1a3f60..d7f1042 100644 >>> --- a/drivers/usb/serial/option.c >>> +++ b/drivers/usb/serial/option.c >>> @@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = { >>> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE >>> MF330 */ >>> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ >>> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ >>> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */ >>> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) }, >>> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) }, >>> { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003), >> 05c6:9025 already has its net interface (#4) supported by the >> qmi_wwan driver so your patch is wrong. >> There is also an ADB interface which I don't think should be driven >> by option. >> >> > The ID is right, and it can be used with the option driver or qmi_wwan. > Ignore my patch, I will move to qmi_wwan in the future ... The serial functions should still be supported by the option driver. Both serial and QMI can be used at the same time, and applications like ModemManager will take advantage of this. What you need to to is to make sure the option driver ignores all the USB interfaces it cannot handle. How to best do that depends on the descriptors - specifically which class codes they use. "lsusb -vd 05c6:9025" should tell you more about that. Assuming that all serial interfaces and the QMI interface all use ff/ff/ff, while the ADB interface probably use ff/42/01, then something like this should work: { USB_DEVICE_AND_INTERFACE_INFO(QUALCOMM_VENDOR_ID, 0x9025, 0xff, 0xff, 0xff), /* Peiker LTE NAD */ .driver_info = (kernel_ulong_t)&net_intf4_blacklist }, Bjørn ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-04 12:41 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-01 16:01 [PATCH] usb: option: Add ID for Peiker LTE NAD Matthias Klein 2014-11-02 3:35 ` Lars Melin 2014-11-02 15:31 ` Matthias Klein 2014-11-04 12:40 ` Bjørn Mork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox