Re: [Patch v7 01/18] ACPI, irq: fix regression casued by 6b9fb7082409

Thomas Gleixner
2014-10-28T18:46:18Z

On Tue, 28 Oct 2014, Bjorn Helgaas wrote:
> The subject should describe the change you're making. "Fix regression
> caused by xxx" doesn't say anything about what the patch does.
>
> On Sun, Oct 26, 2014 at 11:21 PM, Jiang Liu <jiang.liu@linux.intel.com> wrote:
> > When IOAPIC is disabled, acpi_gsi_to_irq() should return gsi directly
> > instead of calling mp_map_gsi_to_irq() to translate gsi to IRQ by IOAPIC.
>
> I don't know what the convention is or if there even is one, but "GSI"
> is even more of an acronym than "IRQ", so I'd capitalize it.
>
> > It fixes https://bugzilla.kernel.org/show_bug.cgi?id=84381.
>
> A line like the following may be useful to those who have to backport this.
>
> Fixes: 6b9fb7082409 ("x86, ACPI, irq: Consolidate algorithm of mapping
> (ioapic, pin) to IRQ number")

The patch is already queued in tip x86/urgent with a proper changelog.

http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=961b6a7003acec4f9d70dabc1a253b783cb74272

Thanks,

tglx