Re: [Patch v7 05/18] ACPI: Correct return value of acpi_dev_resource_address_space()

Bjorn Helgaas
2014-10-27T22:49:29Z

On Sun, Oct 26, 2014 at 11:21 PM, Jiang Liu <jiang.liu@linux.intel.com> wrote:
> Change acpi_dev_resource_address_space() to return failure if the
> acpi_resource structure can't be converted to an ACPI address64
> structure, so caller could correctly detect failure.

Fixes: 046d9ce6820e ("ACPI: Move device resources interpretation code
from PNP to ACPI core")

Possible stable candidate? 046d9ce6820e appeared in v3.8.

> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
> drivers/acpi/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 2ba8f02ced36..782a0d15c25f 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -200,7 +200,7 @@ bool acpi_dev_resource_address_space(struct acpi_resource *ares,
>
> status = acpi_resource_to_address64(ares, &addr);
> if (ACPI_FAILURE(status))
> - return true;
> + return false;
>
> res->start = addr.minimum;
> res->end = addr.maximum;
> --
> 1.7.10.4
>