linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	"Chen, Tiejun" <tiejun.chen@intel.com>,
	Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: Gleb Natapov <gleb@kernel.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Takashi Iwai <tiwai@suse.de>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: fix access memslots w/o hold srcu read lock
Date: Sun, 02 Nov 2014 07:50:29 +0100	[thread overview]
Message-ID: <5455D435.5050405@redhat.com> (raw)
In-Reply-To: <54544A45.1000505@gmail.com>



On 01/11/2014 03:49, Wanpeng Li wrote:
> 
> This is also not enough. I see the warning in the below path during the
> test:
> 
> kvm_arch_vcpu_ioctl_run
> -> kvm_apic_accept_events
> -> kvm_vcpu_reset

Hmm, better bypass the problem altogether:

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index a0f78dbaabee..3e556c68351b 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4579,7 +4579,7 @@ static void vmx_vcpu_reset(struct kvm_vcpu *vcpu)
 		vmcs_write32(TPR_THRESHOLD, 0);
 	}
 
-	kvm_vcpu_reload_apic_access_page(vcpu);
+	kvm_make_request(KVM_REQ_APIC_PAGE_RELOAD, vcpu);
 
 	if (vmx_vm_has_apicv(vcpu->kvm))
 		memset(&vmx->pi_desc, 0, sizeof(struct pi_desc));

(untested)

Paolo

  reply	other threads:[~2014-11-02  6:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  4:33 [PATCH] KVM: x86: fix access memslots w/o hold srcu read lock Wanpeng Li
2014-10-31  5:30 ` Chen, Tiejun
2014-10-31  6:11   ` Wanpeng Li
2014-10-31 10:36   ` Paolo Bonzini
2014-10-31 11:10     ` Wanpeng Li
2014-11-01  2:49     ` Wanpeng Li
2014-11-02  6:50       ` Paolo Bonzini [this message]
2014-11-02  7:10         ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5455D435.5050405@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=gleb@kernel.org \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiejun.chen@intel.com \
    --cc=tiwai@suse.de \
    --cc=wanpeng.li@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).