From: Alexander Graf <agraf@suse.de>
To: "Matwey V. Kornilov" <matwey.kornilov@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Peter Foley <pefoley2@pefoley.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Jiri Kosina <jkosina@suse.cz>,
Randy Dunlap <rdunlap@infradead.org>,
"afaerber@suse.de" <afaerber@suse.de>
Subject: Re: [PATCH] Documentation: Restrict TSC test code to x86
Date: Sun, 02 Nov 2014 09:16:49 +0100 [thread overview]
Message-ID: <5455E871.7080700@suse.de> (raw)
In-Reply-To: <CAJs94EaS5EQ=X9vRJzzApMuj9uiqH78Qq01HFNnRSXHNjeHRGw@mail.gmail.com>
On 02.11.14 08:46, Matwey V. Kornilov wrote:
> I wish I knew. We need KBuild guru to ask how to take into account
> host architecture.
Hrm. At least this patch makes things more consistent with the other
Documentation makefiles:
Documentation/timers/Makefile:hostprogs-$(CONFIG_X86) := hpet_example
Documentation/vDSO/Makefile:hostprogs-$(CONFIG_X86) :=
vdso_standalone_test_x86
But I agree, it is wrong in general - hostprogs should make sure the
host arch matches.
We could maybe just evaluate the host uname output:
ifeq ($(shell uname -m),x86_64)
hostprogs-$(CONFIG_X86) := ...
endif
Then we're double safe ;). Not sure how to easily add x86 to the mix as
well here, but I'm not sure anyone cares. Do people still compile on
32bit x86 hosts? And expect Documentation/ examples to build?
Alex
next prev parent reply other threads:[~2014-11-02 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 0:03 [PATCH] Documentation: Restrict TSC test code to x86 Alexander Graf
2014-10-28 0:07 ` Peter Foley
2014-10-28 12:47 ` Jonathan Corbet
2014-10-28 13:12 ` Alexander Graf
2014-11-01 12:03 ` Matwey V. Kornilov
2014-11-01 21:16 ` Alexander Graf
2014-11-02 7:46 ` Matwey V. Kornilov
2014-11-02 8:16 ` Alexander Graf [this message]
2014-11-02 10:28 ` Matwey V. Kornilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5455E871.7080700@suse.de \
--to=agraf@suse.de \
--cc=afaerber@suse.de \
--cc=corbet@lwn.net \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matwey.kornilov@gmail.com \
--cc=pefoley2@pefoley.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox