From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751114AbaKBIQy (ORCPT ); Sun, 2 Nov 2014 03:16:54 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60814 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbaKBIQw (ORCPT ); Sun, 2 Nov 2014 03:16:52 -0500 Message-ID: <5455E871.7080700@suse.de> Date: Sun, 02 Nov 2014 09:16:49 +0100 From: Alexander Graf User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Matwey V. Kornilov" CC: Jonathan Corbet , Peter Foley , LKML , "linux-doc@vger.kernel.org" , Jiri Kosina , Randy Dunlap , "afaerber@suse.de" Subject: Re: [PATCH] Documentation: Restrict TSC test code to x86 References: <1414454639-7491-1-git-send-email-agraf@suse.de> <20141028084735.6338d01b@lwn.net> <5454CC07.1070605@gmail.com> <54554DBC.3050607@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.11.14 08:46, Matwey V. Kornilov wrote: > I wish I knew. We need KBuild guru to ask how to take into account > host architecture. Hrm. At least this patch makes things more consistent with the other Documentation makefiles: Documentation/timers/Makefile:hostprogs-$(CONFIG_X86) := hpet_example Documentation/vDSO/Makefile:hostprogs-$(CONFIG_X86) := vdso_standalone_test_x86 But I agree, it is wrong in general - hostprogs should make sure the host arch matches. We could maybe just evaluate the host uname output: ifeq ($(shell uname -m),x86_64) hostprogs-$(CONFIG_X86) := ... endif Then we're double safe ;). Not sure how to easily add x86 to the mix as well here, but I'm not sure anyone cares. Do people still compile on 32bit x86 hosts? And expect Documentation/ examples to build? Alex