From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbaKBOPH (ORCPT ); Sun, 2 Nov 2014 09:15:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbaKBOPF (ORCPT ); Sun, 2 Nov 2014 09:15:05 -0500 Message-ID: <54563C5F.10702@redhat.com> Date: Sun, 02 Nov 2014 15:14:55 +0100 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Dmitry Torokhov , Yunkang Tang , Tommy Will CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] Fixes for ALPS driver References: <1412329392-5580-1-git-send-email-pali.rohar@gmail.com> <1414884310-19842-1-git-send-email-pali.rohar@gmail.com> In-Reply-To: <1414884310-19842-1-git-send-email-pali.rohar@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/02/2014 12:25 AM, Pali Rohár wrote: > This patch series tries to fix problems with ALPS dualpoint devices on Dell > Latitude laptops which are probably caused by bugs in Dell BIOS, Dell EC or > in ALPS touchpad firmware itself. > > Root of problems is yet unknown but at least this patch series could eliminate > reporting bogus data to userspace. > > Reported bugs: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1258837 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1320022 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1272624 > https://bugzilla.redhat.com/show_bug.cgi?id=1145954 > > Pali Rohár (4): > input: alps: Do not try to parse data as 3 bytes packet when driver > is out of sync > input: alps: Allow 2 invalid packets without resetting device > input: alps: For protocol V3, do not process data when last packet's > bit7 is set > input: alps: Fix trackstick detection > > drivers/input/mouse/alps.c | 113 +++++++++++++++++++++++++++++++------------- > 1 file changed, 80 insertions(+), 33 deletions(-) Thanks for working on this, patches 1-3 are: Reviewed-by: Hans de Goede Patch 4 is too much work to review on a Sunday :), so I'll leave reviewing it to Dmitry. Regards, Hans