public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Kamil Debski <k.debski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	kgene.kim@samsung.com
Subject: Re: [PATCH] ARM: dts: Add pwm-fan node to the Odroid-U3 board
Date: Mon, 03 Nov 2014 18:16:12 +0100	[thread overview]
Message-ID: <5457B85C.4020105@suse.de> (raw)
In-Reply-To: <1415025804-24274-1-git-send-email-k.debski@samsung.com>

Hi,

Am 03.11.2014 um 15:43 schrieb Kamil Debski:
> Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the
> cooling fan.
> 
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-odroidu3.dts |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> index c8a64be..764bda4 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> @@ -31,6 +31,19 @@
>  			linux,default-trigger = "heartbeat";
>  		};
>  	};
> +
> +	pwm: pwm@139D0000 {
> +		pinctrl-0 = <&pwm0_out>;
> +		pinctrl-names = "default";
> +		samsung,pwm-outputs = <0>;
> +		status = "okay";
> +	};

Please add the pwm label in the .dtsi if necessary and then just do &pwm
{...}; before &usb3503 below.

> +
> +	pwm-fan {
> +		compatible = "pwm-fan";
> +		status = "okay";
> +		pwms = <&pwm 0 10000 0>;
> +	};
>  };
>  
>  &usb3503 {

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg

      reply	other threads:[~2014-11-03 17:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03 14:43 [PATCH] ARM: dts: Add pwm-fan node to the Odroid-U3 board Kamil Debski
2014-11-03 17:16 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5457B85C.4020105@suse.de \
    --to=afaerber@suse.de \
    --cc=k.debski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox