From: Chris Metcalf <cmetcalf@tilera.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>, <dwalter@google.com>,
<richard@nod.at>, Al Viro <viro@ZenIV.linux.org.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arch: tile: kernel: signal.c: Use __copy_from/to_user() instead of __get/put_user()
Date: Tue, 4 Nov 2014 10:42:48 -0500 [thread overview]
Message-ID: <5458F3F8.3030100@tilera.com> (raw)
In-Reply-To: <54559337.7050506@gmail.com>
On 11/1/2014 10:13 PM, Chen Gang wrote:
> setup/restore_sigcontext() want to copy all related registers between
> user and kernel. So use block copy instead of each registers copy. Then
> can let code simple and clearer (which can avoid compiler's warning):
>
> [...]
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/tile/kernel/signal.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/tile/kernel/signal.c b/arch/tile/kernel/signal.c
> index 7c2fecc..f867783 100644
> --- a/arch/tile/kernel/signal.c
> +++ b/arch/tile/kernel/signal.c
> @@ -46,7 +46,6 @@ int restore_sigcontext(struct pt_regs *regs,
> struct sigcontext __user *sc)
> {
> int err = 0;
> - int i;
Taken into the tile tree, but I removed the now-redundant initialization
of err (shown above).
Thanks!
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2014-11-04 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 2:13 [PATCH v2] arch: tile: kernel: signal.c: Use __copy_from/to_user() instead of __get/put_user() Chen Gang
2014-11-04 15:42 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458F3F8.3030100@tilera.com \
--to=cmetcalf@tilera.com \
--cc=dwalter@google.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox