From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbaKDTnr (ORCPT ); Tue, 4 Nov 2014 14:43:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57834 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732AbaKDTnp (ORCPT ); Tue, 4 Nov 2014 14:43:45 -0500 Message-ID: <54592C39.9070904@redhat.com> Date: Tue, 04 Nov 2014 20:42:49 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Fabian Frederick CC: linux-kernel@vger.kernel.org, Steffen Klassert , Herbert Xu , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org Subject: Re: [PATCH 1/1 net-next] esp4: remove assignment in if condition References: <1415129311-12480-1-git-send-email-fabf@skynet.be> In-Reply-To: <1415129311-12480-1-git-send-email-fabf@skynet.be> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2014 08:28 PM, Fabian Frederick wrote: > Signed-off-by: Fabian Frederick > --- > net/ipv4/esp4.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c > index 360b565..9dd66ee 100644 > --- a/net/ipv4/esp4.c > +++ b/net/ipv4/esp4.c > @@ -392,8 +392,11 @@ static int esp_input(struct xfrm_state *x, struct sk_buff *skb) > if (elen <= 0) > goto out; > > - if ((err = skb_cow_data(skb, 0, &trailer)) < 0) > + err = skb_cow_data(skb, 0, &trailer); > + If you already feel the need to change this (?), then please don't add an extra newline here ... > + if (err < 0) > goto out; > + > nfrags = err; > > assoclen = sizeof(*esph); >