Re: [PATCH 2/2 v3] ftracetest: Add a couple of ftrace test cases

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2014/11/05 16:52), Namhyung Kim wrote:
> Hi Steve,
> 
> On Tue, 04 Nov 2014 10:28:47 -0500, Steven Rostedt wrote:
>> +count=`cat trace | grep '()' | grep -v schedule | wc -l`
>> +
>> +if [ $count -ne 0 ]; then
>> +    echo "Graph filtering not working after stack tracer disabled?"
>> +    exit -1
>> +fi
>> +
>> +count=`cat trace | grep 'schedule()' | wc -l` 
>> +if [ $count -eq 0 ]; then
>> +    echo "No schedule traces found?"
>> +    exit -1
> 
> Hmm.. in this case don't we need to call do_reset especially for the
> last testcase?  Maybe we could define a simple function like:
> 
> fail() { # msg
> 	do_reset
> 	echo $1
> 	exit -1
> }

If you want to call do_reset always on exit, you can also use "trap do_reset 0" too.

Thank you,

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com