* [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
@ 2014-10-07 9:12 Sylwester Nawrocki
2014-11-03 23:24 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Sylwester Nawrocki @ 2014-10-07 9:12 UTC (permalink / raw)
To: gregkh
Cc: linux-usb, linux-kernel, pebolle, jg1.han, linux-samsung-soc,
Sylwester Nawrocki
The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
("ARM: SAMSUNG: Remove remaining legacy code"). There are still
some references left, fix that by replacing them with ARCH_S5PV210.
Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
Reported-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Cc: <stable@vger.kernel.org> [3.17+]
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v2:
- updated the commit description.
drivers/usb/host/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 82800a7..6f1d48e 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -220,7 +220,7 @@ config USB_EHCI_SH
config USB_EHCI_EXYNOS
tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
- depends on PLAT_S5P || ARCH_EXYNOS
+ depends on ARCH_S5PV210 || ARCH_EXYNOS
help
Enable support for the Samsung Exynos SOC's on-chip EHCI controller.
@@ -527,7 +527,7 @@ config USB_OHCI_SH
config USB_OHCI_EXYNOS
tristate "OHCI support for Samsung S5P/EXYNOS SoC Series"
- depends on PLAT_S5P || ARCH_EXYNOS
+ depends on ARCH_S5PV210 || ARCH_EXYNOS
help
Enable support for the Samsung Exynos SOC's on-chip OHCI controller.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
2014-10-07 9:12 [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol Sylwester Nawrocki
@ 2014-11-03 23:24 ` Greg KH
2014-11-04 18:33 ` Sylwester Nawrocki
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2014-11-03 23:24 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-usb, linux-kernel, pebolle, jg1.han, linux-samsung-soc
On Tue, Oct 07, 2014 at 11:12:07AM +0200, Sylwester Nawrocki wrote:
> The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
> ("ARM: SAMSUNG: Remove remaining legacy code"). There are still
> some references left, fix that by replacing them with ARCH_S5PV210.
>
> Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> Cc: <stable@vger.kernel.org> [3.17+]
This isn't a stable issue...
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
2014-11-03 23:24 ` Greg KH
@ 2014-11-04 18:33 ` Sylwester Nawrocki
2014-11-04 19:21 ` Paul Bolle
0 siblings, 1 reply; 8+ messages in thread
From: Sylwester Nawrocki @ 2014-11-04 18:33 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb, linux-kernel, pebolle, jg1.han, linux-samsung-soc
On 04/11/14 00:24, Greg KH wrote:
> On Tue, Oct 07, 2014 at 11:12:07AM +0200, Sylwester Nawrocki wrote:
>> > The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
>> > ("ARM: SAMSUNG: Remove remaining legacy code"). There are still
>> > some references left, fix that by replacing them with ARCH_S5PV210.
>> >
>> > Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
>> > Reported-by: Paul Bolle <pebolle@tiscali.nl>
>> > Acked-by: Jingoo Han <jg1.han@samsung.com>
>> > Cc: <stable@vger.kernel.org> [3.17+]
>
> This isn't a stable issue...
Sorry for disturbing then, let me go and read the documentation again.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
2014-11-04 18:33 ` Sylwester Nawrocki
@ 2014-11-04 19:21 ` Paul Bolle
2014-11-04 19:42 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Paul Bolle @ 2014-11-04 19:21 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Greg KH, linux-usb, linux-kernel, jg1.han, linux-samsung-soc
On Tue, 2014-11-04 at 19:33 +0100, Sylwester Nawrocki wrote:
> On 04/11/14 00:24, Greg KH wrote:
> > This isn't a stable issue...
>
> Sorry for disturbing then, let me go and read the documentation again.
If I remember correctly, I asked Sylwester to mark this for stable. So
it's me that should be educated here.
Why is a patch that allows the users of ARCH_S5PV210 to set
USB_EHCI_EXYNOS or USB_OHCI_EXYNOS - which they apparently need - for a
v3.17.y kernel, not a stable issue?
Paul Bolle
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
2014-11-04 19:21 ` Paul Bolle
@ 2014-11-04 19:42 ` Greg KH
2014-11-04 19:52 ` Paul Bolle
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2014-11-04 19:42 UTC (permalink / raw)
To: Paul Bolle
Cc: Sylwester Nawrocki, linux-usb, linux-kernel, jg1.han,
linux-samsung-soc
On Tue, Nov 04, 2014 at 08:21:04PM +0100, Paul Bolle wrote:
> On Tue, 2014-11-04 at 19:33 +0100, Sylwester Nawrocki wrote:
> > On 04/11/14 00:24, Greg KH wrote:
> > > This isn't a stable issue...
> >
> > Sorry for disturbing then, let me go and read the documentation again.
>
> If I remember correctly, I asked Sylwester to mark this for stable. So
> it's me that should be educated here.
>
> Why is a patch that allows the users of ARCH_S5PV210 to set
> USB_EHCI_EXYNOS or USB_OHCI_EXYNOS - which they apparently need - for a
> v3.17.y kernel, not a stable issue?
As it's something that no one seemed to ever need before (i.e. it's not
a regression fix), but it would be a "new feature", I don't think it's
really a stable fix.
But feel free to convince me otherwise :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
2014-11-04 19:42 ` Greg KH
@ 2014-11-04 19:52 ` Paul Bolle
2014-11-05 10:23 ` Sylwester Nawrocki
0 siblings, 1 reply; 8+ messages in thread
From: Paul Bolle @ 2014-11-04 19:52 UTC (permalink / raw)
To: Greg KH
Cc: Sylwester Nawrocki, linux-usb, linux-kernel, jg1.han,
linux-samsung-soc
On Tue, 2014-11-04 at 11:42 -0800, Greg KH wrote:
> As it's something that no one seemed to ever need before (i.e. it's not
> a regression fix), but it would be a "new feature", I don't think it's
> really a stable fix.
>
> But feel free to convince me otherwise :)
Sylwester, was I right in thinking that users of PLAT_S5P, who could set
USB_EHCI_EXYNOS or USB_OHCI_EXYNOS pre v3.17, got, well, transferred to
ARCH_S5PV210 and lost the ability to set one of those symbols in v3.17?
Paul Bolle
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
2014-11-04 19:52 ` Paul Bolle
@ 2014-11-05 10:23 ` Sylwester Nawrocki
2014-11-05 16:25 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Sylwester Nawrocki @ 2014-11-05 10:23 UTC (permalink / raw)
To: Paul Bolle, Greg KH; +Cc: linux-usb, linux-kernel, jg1.han, linux-samsung-soc
On 04/11/14 20:52, Paul Bolle wrote:
> On Tue, 2014-11-04 at 11:42 -0800, Greg KH wrote:
>> > As it's something that no one seemed to ever need before (i.e. it's not
>> > a regression fix), but it would be a "new feature", I don't think it's
>> > really a stable fix.
>> >
>> > But feel free to convince me otherwise :)
>
> Sylwester, was I right in thinking that users of PLAT_S5P, who could set
> USB_EHCI_EXYNOS or USB_OHCI_EXYNOS pre v3.17, got, well, transferred to
> ARCH_S5PV210 and lost the ability to set one of those symbols in v3.17?
Yes, after commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
we lost the ability to enable USB OHCI and EHCI on S5PV210 SoC.
Thus for those who use the mainline kernel (might be rare) with S5PV210 SoC
there is obviously a regression in USB subsystem in v3.17.
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol
2014-11-05 10:23 ` Sylwester Nawrocki
@ 2014-11-05 16:25 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2014-11-05 16:25 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Paul Bolle, linux-usb, linux-kernel, jg1.han, linux-samsung-soc
On Wed, Nov 05, 2014 at 11:23:36AM +0100, Sylwester Nawrocki wrote:
> On 04/11/14 20:52, Paul Bolle wrote:
> > On Tue, 2014-11-04 at 11:42 -0800, Greg KH wrote:
> >> > As it's something that no one seemed to ever need before (i.e. it's not
> >> > a regression fix), but it would be a "new feature", I don't think it's
> >> > really a stable fix.
> >> >
> >> > But feel free to convince me otherwise :)
> >
> > Sylwester, was I right in thinking that users of PLAT_S5P, who could set
> > USB_EHCI_EXYNOS or USB_OHCI_EXYNOS pre v3.17, got, well, transferred to
> > ARCH_S5PV210 and lost the ability to set one of those symbols in v3.17?
>
> Yes, after commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> we lost the ability to enable USB OHCI and EHCI on S5PV210 SoC.
> Thus for those who use the mainline kernel (might be rare) with S5PV210 SoC
> there is obviously a regression in USB subsystem in v3.17.
Ok, I'll add this to 3.17-stable when it hits Linus's tree, thanks.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-11-05 16:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-07 9:12 [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol Sylwester Nawrocki
2014-11-03 23:24 ` Greg KH
2014-11-04 18:33 ` Sylwester Nawrocki
2014-11-04 19:21 ` Paul Bolle
2014-11-04 19:42 ` Greg KH
2014-11-04 19:52 ` Paul Bolle
2014-11-05 10:23 ` Sylwester Nawrocki
2014-11-05 16:25 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).