* [PATCH] drm/panel: ld9040: Update calls to gpiod_get*()
@ 2014-10-23 8:16 Alexandre Courbot
2014-10-23 9:45 ` Andrzej Hajda
2014-11-06 8:51 ` Thierry Reding
0 siblings, 2 replies; 5+ messages in thread
From: Alexandre Courbot @ 2014-10-23 8:16 UTC (permalink / raw)
To: Thierry Reding; +Cc: dri-devel, linux-kernel, gnurou, Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and
remove any direction setting code afterwards.
Currently both forms (with or without the flags argument)
are valid thanks to transitional macros in
<linux/gpio/consumer.h>. These macros will be removed once
all consumers are updated and the flags argument will become
compulsary.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
drivers/gpu/drm/panel/panel-ld9040.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c
index 42ac67b21e9f..dd1d3f2e624e 100644
--- a/drivers/gpu/drm/panel/panel-ld9040.c
+++ b/drivers/gpu/drm/panel/panel-ld9040.c
@@ -336,17 +336,12 @@ static int ld9040_probe(struct spi_device *spi)
if (ret < 0)
return ret;
- ctx->reset_gpio = devm_gpiod_get(dev, "reset");
+ ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(ctx->reset_gpio)) {
dev_err(dev, "cannot get reset-gpios %ld\n",
PTR_ERR(ctx->reset_gpio));
return PTR_ERR(ctx->reset_gpio);
}
- ret = gpiod_direction_output(ctx->reset_gpio, 1);
- if (ret < 0) {
- dev_err(dev, "cannot configure reset-gpios %d\n", ret);
- return ret;
- }
spi->bits_per_word = 9;
ret = spi_setup(spi);
--
2.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/panel: ld9040: Update calls to gpiod_get*()
2014-10-23 8:16 [PATCH] drm/panel: ld9040: Update calls to gpiod_get*() Alexandre Courbot
@ 2014-10-23 9:45 ` Andrzej Hajda
2014-11-06 3:32 ` Alexandre Courbot
2014-11-06 8:51 ` Thierry Reding
1 sibling, 1 reply; 5+ messages in thread
From: Andrzej Hajda @ 2014-10-23 9:45 UTC (permalink / raw)
To: Alexandre Courbot, Thierry Reding; +Cc: gnurou, linux-kernel, dri-devel
On 10/23/2014 10:16 AM, Alexandre Courbot wrote:
> Add the new flags argument to calls of (devm_)gpiod_get*() and
> remove any direction setting code afterwards.
>
> Currently both forms (with or without the flags argument)
> are valid thanks to transitional macros in
> <linux/gpio/consumer.h>. These macros will be removed once
> all consumers are updated and the flags argument will become
> compulsary.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
It needs patch "gpio: Fix gpio direction flags not getting set" to work
correctly. It is not yet present in drm-next. Beside this:
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/gpu/drm/panel/panel-ld9040.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c
> index 42ac67b21e9f..dd1d3f2e624e 100644
> --- a/drivers/gpu/drm/panel/panel-ld9040.c
> +++ b/drivers/gpu/drm/panel/panel-ld9040.c
> @@ -336,17 +336,12 @@ static int ld9040_probe(struct spi_device *spi)
> if (ret < 0)
> return ret;
>
> - ctx->reset_gpio = devm_gpiod_get(dev, "reset");
> + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> if (IS_ERR(ctx->reset_gpio)) {
> dev_err(dev, "cannot get reset-gpios %ld\n",
> PTR_ERR(ctx->reset_gpio));
> return PTR_ERR(ctx->reset_gpio);
> }
> - ret = gpiod_direction_output(ctx->reset_gpio, 1);
> - if (ret < 0) {
> - dev_err(dev, "cannot configure reset-gpios %d\n", ret);
> - return ret;
> - }
>
> spi->bits_per_word = 9;
> ret = spi_setup(spi);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/panel: ld9040: Update calls to gpiod_get*()
2014-10-23 9:45 ` Andrzej Hajda
@ 2014-11-06 3:32 ` Alexandre Courbot
2014-11-06 7:26 ` Andrzej Hajda
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Courbot @ 2014-11-06 3:32 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Alexandre Courbot, Thierry Reding, Linux Kernel Mailing List,
dri-devel@lists.freedesktop.org
On Thu, Oct 23, 2014 at 6:45 PM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> On 10/23/2014 10:16 AM, Alexandre Courbot wrote:
>> Add the new flags argument to calls of (devm_)gpiod_get*() and
>> remove any direction setting code afterwards.
>>
>> Currently both forms (with or without the flags argument)
>> are valid thanks to transitional macros in
>> <linux/gpio/consumer.h>. These macros will be removed once
>> all consumers are updated and the flags argument will become
>> compulsary.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>
> It needs patch "gpio: Fix gpio direction flags not getting set" to work
> correctly. It is not yet present in drm-next. Beside this:
>
> Acked-by: Andrzej Hajda <a.hajda@samsung.com>
The required patch is now merged, can we go on with this patch?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panel: ld9040: Update calls to gpiod_get*()
2014-11-06 3:32 ` Alexandre Courbot
@ 2014-11-06 7:26 ` Andrzej Hajda
0 siblings, 0 replies; 5+ messages in thread
From: Andrzej Hajda @ 2014-11-06 7:26 UTC (permalink / raw)
To: Alexandre Courbot
Cc: Alexandre Courbot, Thierry Reding, Linux Kernel Mailing List,
dri-devel@lists.freedesktop.org
On 11/06/2014 04:32 AM, Alexandre Courbot wrote:
> On Thu, Oct 23, 2014 at 6:45 PM, Andrzej Hajda <a.hajda@samsung.com> wrote:
>> On 10/23/2014 10:16 AM, Alexandre Courbot wrote:
>>> Add the new flags argument to calls of (devm_)gpiod_get*() and
>>> remove any direction setting code afterwards.
>>>
>>> Currently both forms (with or without the flags argument)
>>> are valid thanks to transitional macros in
>>> <linux/gpio/consumer.h>. These macros will be removed once
>>> all consumers are updated and the flags argument will become
>>> compulsary.
>>>
>>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> It needs patch "gpio: Fix gpio direction flags not getting set" to work
>> correctly. It is not yet present in drm-next. Beside this:
>>
>> Acked-by: Andrzej Hajda <a.hajda@samsung.com>
> The required patch is now merged, can we go on with this patch?
>
Yes, for both panels. Thanks.
Regards
Andrzej
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panel: ld9040: Update calls to gpiod_get*()
2014-10-23 8:16 [PATCH] drm/panel: ld9040: Update calls to gpiod_get*() Alexandre Courbot
2014-10-23 9:45 ` Andrzej Hajda
@ 2014-11-06 8:51 ` Thierry Reding
1 sibling, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2014-11-06 8:51 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: dri-devel, linux-kernel, gnurou
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
On Thu, Oct 23, 2014 at 05:16:17PM +0900, Alexandre Courbot wrote:
> Add the new flags argument to calls of (devm_)gpiod_get*() and
> remove any direction setting code afterwards.
>
> Currently both forms (with or without the flags argument)
> are valid thanks to transitional macros in
> <linux/gpio/consumer.h>. These macros will be removed once
> all consumers are updated and the flags argument will become
> compulsary.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> drivers/gpu/drm/panel/panel-ld9040.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-06 8:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 8:16 [PATCH] drm/panel: ld9040: Update calls to gpiod_get*() Alexandre Courbot
2014-10-23 9:45 ` Andrzej Hajda
2014-11-06 3:32 ` Alexandre Courbot
2014-11-06 7:26 ` Andrzej Hajda
2014-11-06 8:51 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox