Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

Guenter Roeck
2014-11-09T23:55:05Z

On 11/09/2014 01:41 PM, Marc Dietrich wrote:
> Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck:
>> Register with kernel power-off handler instead of setting pm_power_off
>> directly. Register with default priority since we don't know any better.
>>
>> Cc: Julian Andres Klode <jak@jak-linux.org>
>> Cc: Marc Dietrich <marvin24@gmx.de>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net
>
> ok, this version (V5) actually switches the device off in contrast to the
> first implementation. Somehow I have to find out why it works at all without
> irqs.
>
> Acked-by: Marc Dietrich <mavin24@gmx.de>
>

Hi Marc,

The most recent version does not turn off interrupts as long as the
infrastructure (architecture code, ie machine_power_off) doesn't
turn it off.

Thanks a lot for (re-)testing.

Guenter