Re: [PATCH v5 36/48] arm64: psci: Register with kernel power-off handler

Mark Rutland
2014-11-06T17:23:11Z

On Thu, Nov 06, 2014 at 04:43:20PM +0000, Guenter Roeck wrote:
> Register with kernel power-off handler instead of setting pm_power_off
> directly.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

I just fetched your current poweroff-handler branch and gave it a spin
on Juno. It looks like this hasn't broken since the last time I tried
it. :)

Tested-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.

> ---
> v5:
> - Rebase to v3.18-rc3
> v4:
> - No change
> v3:
> - Replace poweroff in all newly introduced variables and in text
> with power_off or power-off as appropriate
> - Replace POWEROFF_PRIORITY_xxx with POWER_OFF_PRIORITY_xxx
> v2:
> - Use define to specify poweroff handler priority
>
> arch/arm64/kernel/psci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/psci.c b/arch/arm64/kernel/psci.c
> index 866c1c8..5cab066 100644
> --- a/arch/arm64/kernel/psci.c
> +++ b/arch/arm64/kernel/psci.c
> @@ -359,7 +359,8 @@ static int __init psci_0_2_init(struct device_node *np)
>
> arm_pm_restart = psci_sys_reset;
>
> - pm_power_off = psci_sys_poweroff;
> + register_power_off_handler_simple(psci_sys_poweroff,
> + POWER_OFF_PRIORITY_DEFAULT);
>
> out_put_node:
> of_node_put(np);
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>