From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbaKJQpT (ORCPT ); Mon, 10 Nov 2014 11:45:19 -0500 Received: from mail-ig0-f179.google.com ([209.85.213.179]:44224 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752941AbaKJQpO (ORCPT ); Mon, 10 Nov 2014 11:45:14 -0500 Message-ID: <5460EB92.1090501@gmail.com> Date: Mon, 10 Nov 2014 11:45:06 -0500 From: Austin S Hemmelgarn User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Matt Fleming CC: Borislav Petkov , Mark Salter , Alessandro Zummo , rtc-linux@googlegroups.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Young , "H. Peter Anvin" , Matthew Garrett Subject: Re: [PATCH] rtc: Disable EFI rtc for x86 References: <1412339576-17972-1-git-send-email-matt@console-pimps.org> <20141109182231.GA29337@pd.tnic> <1415618533.14686.239.camel@mfleming-mobl1.ger.corp.intel.com> <201411101723.49197@pali> In-Reply-To: <201411101723.49197@pali> x-hashcash: 1:21:141110:pali.rohar@gmail.com::55ce5924d3c3aee1b84f9c12e573ae4a:97120429fa511e3c x-hashcash: 1:21:141110:matt.fleming@intel.com::ecddff1a123c523ab743f0f772463e1e:141d89432ee56604 x-hashcash: 1:21:141110:bp@alien8.de::ca72734f8ac74123fe9ee05486f51ff0:5f2a3eb4757758f6 x-hashcash: 1:21:141110:msalter@redhat.com::ed8121e739fb8afdce8afa9a38d8b675:b1f057926504b x-hashcash: 1:21:141110:a.zummo@towertech.it::c8582a14b70dab6871bb23471cb75079:a344f05017667352 x-hashcash: 1:21:141110:rtc-linux@googlegroups.com::dbca236d56bb54e84d081dd010c99387:ee26df77601c501 x-hashcash: 1:21:141110:linux-efi@vger.kernel.org::ba4145912e9c511b19bf417958c66fde:372d78fd5a6cec33 x-hashcash: 1:21:141110:linux-kernel@vger.kernel.org::cf09efda2917030317bf94b5f9a6465c:f77758785f94e689 x-hashcash: 1:21:141110:dyoung@redhat.com::eaaa4da389de7a0ca7216d6eb9989359:44e89454f5397b2a x-hashcash: 1:21:141110:hpa@zytor.com::9e1e65a5ebf547a686af8ef1cf506329:229b10d94bab5c86 x-hashcash: 1:21:141110:mjg59@srcf.ucam.org::eaed6ac7b5ba0349b488842354cc11b5:a1873e4b40ba9bc9 x-stampprotocols: hashcash:1:17;mbound:0:10:3000:5000 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms020105030201000609040506" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms020105030201000609040506 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2014-11-10 11:23, Pali Roh=C3=A1r wrote: > On Monday 10 November 2014 12:22:13 Matt Fleming wrote: >> On Sun, 2014-11-09 at 19:22 +0100, Borislav Petkov wrote: >>> On Sun, Nov 09, 2014 at 06:37:46PM +0100, Pali Roh=C3=A1r wrote: >>>> this patch totally disabled efi rfc driver on x86 machines >>>> at compile time. But on some x86 machines it working >>>> without crash and reading from file >>>> /sys/class/rtc/rtc*/since_epoch returns correct >>>> information. So why to disable compiling driver on >>>> machines where driver working? >>> >>> Sounds like we need an efi=3Drtc_enable knob for people who >>> what to use it... >> >> I'm not so sure. By and large, the EFI runtime Time services >> just don't work very well on x86. Just because they work >> sometimes, doesn't actually mean it's a good idea to use >> them. >> >> The one scenario where the time services are useful is early >> on during boot when we want to get the timezone information. >> I have vague recollections of someone working on that. > > On laptop Dell Latitude E6440 with 64bit kernel 3.17-rc6 (where > was rtc-efi.ko enabled at compile time for x86) it working fine > without crash. So I think that other Dell machines could work > too. > I can also confirm that it works correctly on a number of ASUS and=20 ASrock desktop motherboards with the most recent BIOS updates, and on a=20 Lenovo Thinkpad L540. I can however confirm that it DOES NOT work=20 however on an Acer Aspire V5-131 system, though I had never updated the=20 BIOS on that one, so it may work correctly with a newer BIOS version. > Maybe problems which were reported are only specific for 32bit > UEFI? Or 32bit kernels? > > And I think that if I know that efi time service working on > machine, I should be able to use it with mainline kernel (without > hacking Kconfig to enable it and so...). > I agree, without it you need PC CMOS RTC support to access the RTC on=20 most systems, which in turn means that you have to enable the CSM in the = EFI firmware, which is annoying cause you can't easily dual boot windows = with secure boot when the CSM is enabled. --------------ms020105030201000609040506 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFuDCC BbQwggOcoAMCAQICAw9gVDANBgkqhkiG9w0BAQ0FADB5MRAwDgYDVQQKEwdSb290IENBMR4w HAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmlu ZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZzAeFw0xNDA4 MDgxMTMwNDRaFw0xNTAyMDQxMTMwNDRaMGMxGDAWBgNVBAMTD0NBY2VydCBXb1QgVXNlcjEj MCEGCSqGSIb3DQEJARYUYWhmZXJyb2luN0BnbWFpbC5jb20xIjAgBgkqhkiG9w0BCQEWE2Fo ZW1tZWxnQG9oaW9ndC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDdmm8R BM5D6fGiB6rpogPZbLYu6CkU6834rcJepfmxKnLarYUYM593/VGygfaaHAyuc8qLaRA3u1M0 Qp29flqmhv1VDTBZ+zFu6JgHjTDniBii1KOZRo0qV3jC5NvaS8KUM67+eQBjm29LhBWVi3+e a8jLxmogFXV0NGej+GHIr5zA9qKz2WJOEoGh0EfqZ2MQTmozcGI43/oqIYhRj8fRMkWXLUAF WsLzPQMpK19hD8fqwlxQWhBV8gsGRG54K5pyaQsjne7m89SF5M8JkNJPH39tHEvfv2Vhf7EM Y4WGyhLAULSlym1AI1uUHR1FfJaj3AChaEJZli/AdajYsqc7AgMBAAGjggFZMIIBVTAMBgNV HRMBAf8EAjAAMFYGCWCGSAGG+EIBDQRJFkdUbyBnZXQgeW91ciBvd24gY2VydGlmaWNhdGUg Zm9yIEZSRUUgaGVhZCBvdmVyIHRvIGh0dHA6Ly93d3cuQ0FjZXJ0Lm9yZzAOBgNVHQ8BAf8E BAMCA6gwQAYDVR0lBDkwNwYIKwYBBQUHAwQGCCsGAQUFBwMCBgorBgEEAYI3CgMEBgorBgEE AYI3CgMDBglghkgBhvhCBAEwMgYIKwYBBQUHAQEEJjAkMCIGCCsGAQUFBzABhhZodHRwOi8v b2NzcC5jYWNlcnQub3JnMDEGA1UdHwQqMCgwJqAkoCKGIGh0dHA6Ly9jcmwuY2FjZXJ0Lm9y Zy9yZXZva2UuY3JsMDQGA1UdEQQtMCuBFGFoZmVycm9pbjdAZ21haWwuY29tgRNhaGVtbWVs Z0BvaGlvZ3QuY29tMA0GCSqGSIb3DQEBDQUAA4ICAQCr4klxcZU/PDRBpUtlb+d6JXl2dfto OUP/6g19dpx6Ekt2pV1eujpIj5whh5KlCSPUgtHZI7BcksLSczQbxNDvRu6LNKqGJGvcp99k cWL1Z6BsgtvxWKkOmy1vB+2aPfDiQQiMCCLAqXwHiNDZhSkwmGsJ7KHMWgF/dRVDnsl6aOQZ jAcBMpUZxzA/bv4nY2PylVdqJWp9N7x86TF9sda1zRZiyUwy83eFTDNzefYPtc4MLppcaD4g Wt8U6T2ffQfCWVzDirhg4WmDH3MybDItjkSB2/+pgGOS4lgtEBMHzAGQqQ+5PojTHRyqu9Jc O59oIGrTaOtKV9nDeDtzNaQZgygJItJi9GoAl68AmIHxpS1rZUNV6X8ydFrEweFdRTVWhUEL 70Cnx84YBojXv01LYBSZaq18K8cERPLaIrUD2go+2ffjdE9ejvYDhNBllY+ufvRizIjQA1uC OdktVAN6auQob94kOOsWpoMSrzHHvOvVW/kbokmKzaLtcs9+nJoL+vPi2AyzbaoQASVZYOGW pE3daA0F5FJfcPZKCwd5wdnmT3dU1IRUxa5vMmgjP20lkfP8tCPtvZv2mmI2Nw5SaXNY4gVu WQrvkV2in+TnGqgEIwUrLVbx9G6PSYZZs07czhO+Q1iVuKdAwjL/AYK0Us9v50acIzbl5CWw ZGj3wjGCA6EwggOdAgEBMIGAMHkxEDAOBgNVBAoTB1Jvb3QgQ0ExHjAcBgNVBAsTFWh0dHA6 Ly93d3cuY2FjZXJ0Lm9yZzEiMCAGA1UEAxMZQ0EgQ2VydCBTaWduaW5nIEF1dGhvcml0eTEh MB8GCSqGSIb3DQEJARYSc3VwcG9ydEBjYWNlcnQub3JnAgMPYFQwCQYFKw4DAhoFAKCCAfUw GAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTQxMTEwMTY0NTA2 WjAjBgkqhkiG9w0BCQQxFgQUKmYW/BnaBA096zNa5fSzHQUxKPIwbAYJKoZIhvcNAQkPMV8w XTALBglghkgBZQMEASowCwYJYIZIAWUDBAECMAoGCCqGSIb3DQMHMA4GCCqGSIb3DQMCAgIA gDANBggqhkiG9w0DAgIBQDAHBgUrDgMCBzANBggqhkiG9w0DAgIBKDCBkQYJKwYBBAGCNxAE MYGDMIGAMHkxEDAOBgNVBAoTB1Jvb3QgQ0ExHjAcBgNVBAsTFWh0dHA6Ly93d3cuY2FjZXJ0 Lm9yZzEiMCAGA1UEAxMZQ0EgQ2VydCBTaWduaW5nIEF1dGhvcml0eTEhMB8GCSqGSIb3DQEJ ARYSc3VwcG9ydEBjYWNlcnQub3JnAgMPYFQwgZMGCyqGSIb3DQEJEAILMYGDoIGAMHkxEDAO BgNVBAoTB1Jvb3QgQ0ExHjAcBgNVBAsTFWh0dHA6Ly93d3cuY2FjZXJ0Lm9yZzEiMCAGA1UE AxMZQ0EgQ2VydCBTaWduaW5nIEF1dGhvcml0eTEhMB8GCSqGSIb3DQEJARYSc3VwcG9ydEBj YWNlcnQub3JnAgMPYFQwDQYJKoZIhvcNAQEBBQAEggEAzLFP31mZJKW5KprL4Wu63TBHZIFz 5nsgL+rE6vPAd9S6RO2b1NIwzba0HZwS8Y8bQGHNMDRQvoXXyEAXhTDThaVVhFjg6JihAGer zvsaDbIC5ulw7ELLLMCTe07w4REYuL9nkMTFmQmy7nNVH79Zg6hhFgo6yAtTDhMcJhen7ehe kyG7isljUHws4xbEGRr1Y1WKwCF3X/ikEcgRjZK5kHHL6i5QSfASM2EY1ForKxjgi6yBr80w ea6Bgj4ETP1aSdIRFo1MQeyPuIuBOv1uN5OPIk+N8bDEhckTwGkE6uFnQ+OOvisv2S8Em1xk 3BpduT/dRT6ZDp/Y7G+a21jWBgAAAAAAAA== --------------ms020105030201000609040506--