From: "Andreas Färber" <afaerber@suse.de>
To: Liviu Dudau <Liviu.Dudau@arm.com>,
arm@kernel.org, Olof Johansson <olof@lixom.net>
Cc: Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
device tree <devicetree@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] arm64: Add Juno SoC device tree.
Date: Mon, 10 Nov 2014 20:05:42 +0100 [thread overview]
Message-ID: <54610C86.9090002@suse.de> (raw)
In-Reply-To: <1415618875-8469-3-git-send-email-Liviu.Dudau@arm.com>
Hi,
Am 10.11.2014 um 12:27 schrieb Liviu Dudau:
> diff --git a/arch/arm64/boot/dts/juno.dts b/arch/arm64/boot/dts/juno.dts
> new file mode 100644
> index 0000000..7f998de
> --- /dev/null
> +++ b/arch/arm64/boot/dts/juno.dts
> @@ -0,0 +1,374 @@
> +/*
> + * ARM Ltd. Juno Plaform
"Platform"
> + *
Shouldn't this mention a license, ideally dual-licensed?
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> + model = "Juno";
> + compatible = "arm,juno", "arm,vexpress";
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + aliases {
> + serial0 = &soc_uart0;
> + };
> +
> + cpus {
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + A53_0:cpu@100 {
[snip]
Can you please add a space after colon, like you did for non-CPU nodes?
Regards,
Andreas
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
next prev parent reply other threads:[~2014-11-10 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 11:27 [PATCH v2 0/2] arm64: Add support for Juno development board Liviu Dudau
2014-11-10 11:27 ` [PATCH v2 1/2] arm64: Create link to include/dt-bindings to enable C preprocessor use Liviu Dudau
2014-11-10 11:27 ` [PATCH v2 2/2] arm64: Add Juno SoC device tree Liviu Dudau
2014-11-10 17:42 ` Olof Johansson
2014-11-10 20:19 ` Liviu Dudau
2014-11-10 19:05 ` Andreas Färber [this message]
2014-11-10 20:00 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54610C86.9090002@suse.de \
--to=afaerber@suse.de \
--cc=Liviu.Dudau@arm.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox