From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Chen Yucong <slaoub@gmail.com>, <tony.luck@intel.com>,
<ak@linux.intel.com>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] x86, mce, severity: extend the the mce_severity mechanism to handle UCNA/DEFERRED error
Date: Mon, 10 Nov 2014 17:03:49 -0600 [thread overview]
Message-ID: <54614455.7070700@amd.com> (raw)
In-Reply-To: <20141110221728.GA23419@pd.tnic>
On 11/10/2014 4:17 PM, Borislav Petkov wrote:
> On Mon, Nov 10, 2014 at 04:06:00PM -0600, Aravind Gopalakrishnan wrote:
>>> + MCESEV(
>>> + DEFERRED, "Deferred error",
>>> + NOSER, MASK(MCI_STATUS_UC|MCI_STATUS_DEFERRED|MCI_STATUS_POISON, MCI_STATUS_DEFERRED)
>>> ),
>> We don't need to have MCI_STATUS_POISON in the MASK() here as a deferred
>> error is indicated by a {UC=0, Deferred = 1}
>> (Older docs might be unclear on that..)
> Well, I think that's ok because the MASK() macro actually makes the
> check do:
>
> look at bits MCI_STATUS_UC|MCI_STATUS_DEFERRED|MCI_STATUS_POISON and of
> them three MCI_STATUS_DEFERRED has to be the only one set.
>
> And that makes sense - we want deferred errors where we didn't attempt
> to consume poisoned data (which is signalled by MCI_STATUS_POISON)....
Yeah, makes sense.
Reviewed-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Thanks,
-Aravind.
next prev parent reply other threads:[~2014-11-10 23:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 1:40 [PATCH v3 0/2]RAS: add the support for handling UCNA/DEFERRED error Chen Yucong
2014-11-08 1:40 ` [PATCH v3 1/2] x86, mce, severity: extend the the mce_severity mechanism to handle " Chen Yucong
2014-11-10 22:06 ` Aravind Gopalakrishnan
2014-11-10 22:17 ` Borislav Petkov
2014-11-10 23:03 ` Aravind Gopalakrishnan [this message]
2014-11-10 23:32 ` Luck, Tony
2014-11-11 8:56 ` Borislav Petkov
2014-11-11 18:44 ` Luck, Tony
2014-11-12 1:03 ` Chen Yucong
2014-11-12 18:28 ` Luck, Tony
2014-11-08 1:40 ` [PATCH v3 2/2] x86, mce: support memory error recovery for both UCNA and Deferred error in machine_check_poll Chen Yucong
2014-11-10 19:06 ` Borislav Petkov
2014-11-10 21:37 ` Borislav Petkov
2014-11-10 21:44 ` Luck, Tony
2014-11-10 21:47 ` Borislav Petkov
2014-11-10 16:42 ` [PATCH v3 0/2]RAS: add the support for handling UCNA/DEFERRED error Borislav Petkov
2014-11-10 18:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54614455.7070700@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slaoub@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox