public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: jonghwa3.lee@samsung.com
To: "Tc, Jenny" <jenny.tc@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"sre@kernel.org" <sre@kernel.org>,
	"dbaryshkov@gmail.com" <dbaryshkov@gmail.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"anton@enomsg.org" <anton@enomsg.org>,
	"pavel@ucw.cz" <pavel@ucw.cz>
Subject: Re: [PATCH 2/3] power: core: Add variables related temperature to power_supply_info.
Date: Tue, 11 Nov 2014 09:30:24 +0900	[thread overview]
Message-ID: <546158A0.5000707@samsung.com> (raw)
In-Reply-To: <20ADAB092842284E95860F279283C5642ED9EDE3@BGSMSX104.gar.corp.intel.com>

On 2014년 11월 10일 20:16, Tc, Jenny wrote:

>> @@ -241,6 +241,8 @@ struct power_supply_info {
>>  	int charge_empty_design;
>>  	int energy_full_design;
>>  	int energy_empty_design;
>> +	int temperature_max;
>> +	int temperature_min;
>>  	int use_for_apm;
>>  };
> 
> 
> The CC,CV and restart threshold would vary based on the battery temperature
> So I would suggest to have temperature zone table as part  of battery info
> along with other attributes.
> 
> int iterm; //charge termination current (used to stop charging)
> int temp_zone_count; // number of temperature zone tables present
> struct batt_temp_mon_table temp_mon_tbl[MAX_TEMP_MON_TABLE]; //temperature zone table array
> 
> struct  batt_temp_mon_table {
> 	 short int temp_max;
> 	 short int cc;
> 	 short int cv;
> 	 short int vbat_vchk_drop_uv;
> 	 short int temp_min;
> };
> 


IMO, throttling cc/cv according the temperature can be done via thermal fw
interface. However voltage drop and charging termination current can be added here.


Jonghwa

> -Jenny
> 
> 



  reply	other threads:[~2014-11-11  0:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 10:58 [RFC PATCH 0/3] power: Generic interface to get battery specification Jonghwa Lee
2014-10-07 10:58 ` [PATCH 1/3] power: core: Add generic " Jonghwa Lee
2014-11-08 10:13   ` Tc, Jenny
2014-11-10  1:10     ` jonghwa3.lee
2014-11-10  3:41       ` Tc, Jenny
2014-10-07 10:58 ` [PATCH 2/3] power: core: Add variables related temperature to power_supply_info Jonghwa Lee
2014-11-10 11:16   ` Tc, Jenny
2014-11-11  0:30     ` jonghwa3.lee [this message]
2014-11-11  4:56       ` Tc, Jenny
2014-11-11 20:42         ` Pavel Machek
2014-11-12  3:45           ` Tc, Jenny
2014-10-07 10:58 ` [PATCH 3/3] power: of_battery: Initial support for of-based battery specification driver Jonghwa Lee
2014-10-09 10:44   ` Pavel Machek
2015-01-22  0:54 ` [RFC PATCH 0/3] power: Generic interface to get battery specification Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546158A0.5000707@samsung.com \
    --to=jonghwa3.lee@samsung.com \
    --cc=anton@enomsg.org \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=jenny.tc@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox