Re: [RESEND PATCH 1/2] extcon: gpio: Add dt support for the driver

Felipe Balbi
2014-11-05T18:30:15Z

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

On Wed, Nov 05, 2014 at 08:59:47PM +0530, George Cherian wrote:
> Add device tree support to extcon-gpio driver.
> Add devicetree binding documentation
>
> While at that
> - Cleanup the pdata as there are no users for the same.

should be a patch of its own.

> - Convert the driver to use gpiod_* API's.

should be a patch of its own.

> - Some gpio's can sleep while reading, so always use gpio_get_value_cansleep

doesn't explain the fact that you have such a platform. Make it clear
that you have a platform supported in mainline which uses a GPIO from an
external i2c I/O expander and because of that you need to use can_sleep.

Should also be a patch of its own, as it was before.

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]