Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

[Chen Gang]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1391 bytes --]

Thank you for your work.

And also please help check the other patch for gdb about tile,
when you have time.

And I also want to consult, can tile be run under qemu or other
simulators? Welcome any ideas, suggestions, and completions.

Thanks.

Send from Lenovo A788t.

Chris Metcalf <cmetcalf@ezchip.com> wrote:

>On 11/9/2014 5:32 AM, Chen Gang wrote:
>> 'gxio_mpipe_adjust_timestamp', 'gxio_mpipe_link_instance',
>> 'gxio_mpipe_get_timestamp', and 'gxio_mpipe_set_timestamp' may be use by
>> other tile modules, so export them.
>>
>> The related error (with allmodconfig under tile):
>>
>>      MODPOST 4002 modules
>>    ERROR: "gxio_mpipe_link_instance" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>>    ERROR: "gxio_mpipe_get_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>>    ERROR: "gxio_mpipe_set_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>>    ERROR: "gxio_mpipe_adjust_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>>
>> Signed-off-by: Chen Gang<gang.chen.5i5j@gmail.com>
>> ---
>>   arch/tile/gxio/mpipe.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>
>Thanks!  Taken into the tile tree.
>
>-- 
>Chris Metcalf, EZChip Semiconductor
>http://www.ezchip.com
>
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

[Chris Metcalf]

On 11/11/2014 7:16 PM, Chen Gang wrote:
> And I also want to consult, can tile be run under qemu or other
> simulators? Welcome any ideas, suggestions, and completions.

Our use of qemu so far as been purely in the context of virtualization,
where it functions as the KVM driver.  No one has looked into using qemu
as an instruction simulator, for example.  Patches welcome :-)

We do have a simulator, but for the time being, it's only available
as part of chip sales to our customers.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

[Chen Gang]

On 11/13/14 4:18, Chris Metcalf wrote:
> On 11/11/2014 7:16 PM, Chen Gang wrote:
>> And I also want to consult, can tile be run under qemu or other
>> simulators? Welcome any ideas, suggestions, and completions.
> 
> Our use of qemu so far as been purely in the context of virtualization,
> where it functions as the KVM driver.  No one has looked into using qemu
> as an instruction simulator, for example.  Patches welcome :-)
> 

OK, thank you for your information. And excuse me, at present, I have 
no enough time resources (maybe neither have ability) for constructing
tile qemu instruction simulator.

> We do have a simulator, but for the time being, it's only available
> as part of chip sales to our customers.
> 

OK, thanks. Next, I shall consult toolchains tile members for it to try
to find another ways for virtual environments (e.g. binutils/sim,
although I can not find tile under binutils/sim).

If I really can not find any virtual environments for tile, I have to
only try to test tile toolchains (gcc/binutils/libc) under full
cross-building environments, and skip tests under virtual environments.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

[PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

[Chen Gang]

'gxio_mpipe_adjust_timestamp', 'gxio_mpipe_link_instance',
'gxio_mpipe_get_timestamp', and 'gxio_mpipe_set_timestamp' may be use by
other tile modules, so export them.

The related error (with allmodconfig under tile):

    MODPOST 4002 modules
  ERROR: "gxio_mpipe_link_instance" [drivers/net/ethernet/tile/tile_net.ko] undefined!
  ERROR: "gxio_mpipe_get_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
  ERROR: "gxio_mpipe_set_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
  ERROR: "gxio_mpipe_adjust_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/tile/gxio/mpipe.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/tile/gxio/mpipe.c b/arch/tile/gxio/mpipe.c
index 320ff5e..6f00e985 100644
--- a/arch/tile/gxio/mpipe.c
+++ b/arch/tile/gxio/mpipe.c
@@ -463,6 +463,7 @@ int gxio_mpipe_set_timestamp(gxio_mpipe_context_t *context,
 					    (uint64_t)ts->tv_nsec,
 					    (uint64_t)cycles);
 }
+EXPORT_SYMBOL_GPL(gxio_mpipe_set_timestamp);
 
 int gxio_mpipe_get_timestamp(gxio_mpipe_context_t *context,
 			     struct timespec *ts)
@@ -485,11 +486,13 @@ int gxio_mpipe_get_timestamp(gxio_mpipe_context_t *context,
 	}
 	return ret;
 }
+EXPORT_SYMBOL_GPL(gxio_mpipe_get_timestamp);
 
 int gxio_mpipe_adjust_timestamp(gxio_mpipe_context_t *context, int64_t delta)
 {
 	return gxio_mpipe_adjust_timestamp_aux(context, delta);
 }
+EXPORT_SYMBOL_GPL(gxio_mpipe_adjust_timestamp);
 
 /* Get our internal context used for link name access.  This context is
  *  special in that it is not associated with an mPIPE service domain.
@@ -542,6 +545,7 @@ int gxio_mpipe_link_instance(const char *link_name)
 
 	return gxio_mpipe_info_instance_aux(context, name);
 }
+EXPORT_SYMBOL_GPL(gxio_mpipe_link_instance);
 
 int gxio_mpipe_link_enumerate_mac(int idx, char *link_name, uint8_t *link_mac)
 {
-- 
1.9.3

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

[Chris Metcalf]

On 11/9/2014 5:32 AM, Chen Gang wrote:
> 'gxio_mpipe_adjust_timestamp', 'gxio_mpipe_link_instance',
> 'gxio_mpipe_get_timestamp', and 'gxio_mpipe_set_timestamp' may be use by
> other tile modules, so export them.
>
> The related error (with allmodconfig under tile):
>
>      MODPOST 4002 modules
>    ERROR: "gxio_mpipe_link_instance" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>    ERROR: "gxio_mpipe_get_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>    ERROR: "gxio_mpipe_set_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>    ERROR: "gxio_mpipe_adjust_timestamp" [drivers/net/ethernet/tile/tile_net.ko] undefined!
>
> Signed-off-by: Chen Gang<gang.chen.5i5j@gmail.com>
> ---
>   arch/tile/gxio/mpipe.c | 4 ++++
>   1 file changed, 4 insertions(+)

Thanks!  Taken into the tile tree.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com