From: "HATAYAMA, Daisuke" <d.hatayama@jp.fujitsu.com>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: vgoyal@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp,
anderson@redhat.com, kexec@lists.infradead.org,
ebiederm@xmission.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdump, x86: report actual value of phys_base in VMCOREINFO
Date: Thu, 13 Nov 2014 17:30:21 +0900 [thread overview]
Message-ID: <54646C1D.1050102@jp.fujitsu.com> (raw)
In-Reply-To: <20141113090657.2578f087@hananiah.suse.cz>
(2014/11/13 17:06), Petr Tesarik wrote:
> On Thu, 13 Nov 2014 09:17:09 +0900 (JST)
> HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
>
>> From: Vivek Goyal <vgoyal@redhat.com>
>> Subject: Re: [PATCH] kdump, x86: report actual value of phys_base in VMCOREINFO
>> Date: Wed, 12 Nov 2014 17:12:05 -0500
>>
>>> On Wed, Nov 12, 2014 at 03:40:42PM +0900, HATAYAMA Daisuke wrote:
>>>> Currently, VMCOREINFO note information reports the virtual address of
>>>> phys_base that is assigned to symbol phys_base. But this doesn't make
>>>> sense because to refer to value of the phys_base, it's necessary to
>>>> get the value of phys_base itself we are now about to refer to.
>>>>
>>>
>>> Hi Hatayama,
>>>
>>> /proc/vmcore ELF headers have virtual address information and using
>>> that you should be able to read actual value of phys_base. gdb deals
>>> with virtual addresses all the time and can read value of any symbol
>>> using those headers.
>>>
>>> So I am not sure what's the need for exporting actual value of
>>> phys_base.
>>>
>>
>> Sorry, my logic in the patch description was wrong. For /proc/vmcore,
>> there's enough information for makedumpdile to get phys_base. It's
>> correct. The problem here is that other crash dump mechanisms that run
>> outside Linux kernel independently don't have information to get
>> phys_base.
>
> Yes, but these mechanisms won't be able to read VMCOREINFO either, will
> they?
>
I don't intend such sophisticated function only by VMCOREINFO.
Search vmcore for VMCOREINFO using strings + grep before opening it by crash.
I intend that only here.
--
Thanks.
HATAYAMA, Daisuke
next prev parent reply other threads:[~2014-11-13 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 6:40 [PATCH] kdump, x86: report actual value of phys_base in VMCOREINFO HATAYAMA Daisuke
2014-11-12 8:14 ` Petr Tesarik
2014-11-13 0:32 ` HATAYAMA Daisuke
2014-11-12 22:12 ` Vivek Goyal
2014-11-13 0:17 ` HATAYAMA Daisuke
2014-11-13 8:06 ` Petr Tesarik
2014-11-13 8:30 ` HATAYAMA, Daisuke [this message]
2014-11-13 14:25 ` Vivek Goyal
2014-11-13 14:48 ` Petr Tesarik
2014-11-14 1:42 ` HATAYAMA Daisuke
2014-11-14 8:31 ` Petr Tesarik
2014-11-14 9:54 ` HATAYAMA Daisuke
2014-11-14 12:36 ` Petr Tesarik
2014-11-17 5:22 ` HATAYAMA Daisuke
2014-11-14 1:31 ` HATAYAMA Daisuke
2014-11-17 20:38 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54646C1D.1050102@jp.fujitsu.com \
--to=d.hatayama@jp.fujitsu.com \
--cc=anderson@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ptesarik@suse.cz \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox