From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933803AbaKMSoK (ORCPT ); Thu, 13 Nov 2014 13:44:10 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:34327 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933560AbaKMSoD (ORCPT ); Thu, 13 Nov 2014 13:44:03 -0500 Message-ID: <5464FBCC.7060307@ti.com> Date: Thu, 13 Nov 2014 20:43:24 +0200 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Len Brown , Pavel Machek , , Ulf Hansson , , , , Subject: Re: [PATCH] PM / Domains: restore calling of .suspend/resume_noirq() callbacks References: <1415808047-23455-1-git-send-email-grygorii.strashko@ti.com> <2997289.NEH22PNoYM@vostro.rjw.lan> In-Reply-To: <2997289.NEH22PNoYM@vostro.rjw.lan> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 11/13/2014 03:33 AM, Rafael J. Wysocki wrote: > On Wednesday, November 12, 2014 06:00:47 PM Grygorii Strashko wrote: >> Now .suspend/resume_noirq() callbacks will not be called during >> system wide suspend/resume for devices which belongs to some GPD. >> It seems, that this change was accidentally introduced by >> commit d23b9b00cdde ("PM / Domains: Rework system suspend callback >> routines (v2)"). > > I'm not sure if that was really accidentally. > > Can you describe the problem that the change below is attempting to > address, without going to much into the history? IOW, what's that > doesn't work right now? There are no real issues - now in Kernel there are no users of GPD which use "noirq" callbacks. As of now, I'm trying to use GPD for Keyatone2, so I'm studying it and playing with it to understand all benefits and disadvantages of such solution. So, I've found this issue, but not found any description of why calls of these callbacks have been removed. I'd very appreciate if can point me on? > >> This patch restores calling of .suspend/resume_noirq() callbacks >> for devices from GPD during system wide suspend/resume. >> >> Signed-off-by: Grygorii Strashko >> --- >> drivers/base/power/domain.c | 14 +++++++++++--- >> 1 file changed, 11 insertions(+), 3 deletions(-) >> ... Regards, -grygorii