From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755026AbaKNKJL (ORCPT ); Fri, 14 Nov 2014 05:09:11 -0500 Received: from mout.web.de ([212.227.17.12]:52707 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806AbaKNKJJ (ORCPT ); Fri, 14 Nov 2014 05:09:09 -0500 Message-ID: <5465D4B2.4020000@users.sourceforge.net> Date: Fri, 14 Nov 2014 11:08:50 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Julia Lawall , Joe Perches CC: Coccinelle , LKML Subject: Re: [Cocci] spatch for trivial pointer comparison style? References: <1415908529.4223.11.camel@perches.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ewlkaDKefEqOMlHOzv+7/nUNDs9rit46J81noo0u6AZe1+JGQfJ 2Oto06XkCW9PEfH74w/YR0w7Iab3KUclV28P7/gPfZ6RmJ3Ni6A5892VggLa1DS4i/fr8CO 8l5Qxy5aWJ/BINuUArAcNxmz0IUxqUdp/Kv9jibOrCMkOwnqOyFp9QhpsH4XUAGTuD1BNLw i/YnWPer8NOfd5GPNUFow== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I don't think that the change is desirable in all cases. There are > functions like kmalloc where NULL means failure and !p seems like the > reasonable choice. But there maybe other cases where NULL is somehow > a meaningful value. How do you think about to adjust checks for null pointers not only in Linux source files but also in other applications? Are there any more software design challenges to consider with the definition of the preprocessor symbol "NULL"? Regards, Markus