public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq: Add IRQ 0 to domain debug file
Date: Sat, 15 Nov 2014 21:01:57 +0800	[thread overview]
Message-ID: <54674EC5.1050506@linux.intel.com> (raw)
In-Reply-To: <1416050840-24721-1-git-send-email-dbaryshkov@gmail.com>

On 2014/11/15 19:27, Dmitry Eremin-Solenikov wrote:
> Currently irq_domain_mapping debugfs file dumps IRQ information starting
> from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete
> picture of IRQ/domains mappings.
Hi Dmitry,
	For most irqdomain interfaces, they treat irq0 as invalid
interrupt. But on x86, it's possible to use irq0 for timer. It causes
may confusion when enabling irqdomain for x86.
Regards!
Gerry

> 
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  kernel/irq/irqdomain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 6534ff6..0e0c7a8 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -585,7 +585,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
>  		      "chip name", (int)(2 * sizeof(void *) + 2), "chip data",
>  		      "active", "type", "domain");
>  
> -	for (i = 1; i < nr_irqs; i++) {
> +	for (i = 0; i < nr_irqs; i++) {
>  		desc = irq_to_desc(i);
>  		if (!desc)
>  			continue;
> 

  reply	other threads:[~2014-11-15 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 11:27 [PATCH] genirq: Add IRQ 0 to domain debug file Dmitry Eremin-Solenikov
2014-11-15 13:01 ` Jiang Liu [this message]
2014-11-15 15:20   ` Dmitry Eremin-Solenikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54674EC5.1050506@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox