From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kever Yang <kever.yang@rock-chips.com>,
Paul Zimmerman <paulz@synopsys.com>, Felipe Balbi <balbi@ti.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>,
romain.perier@gmail.com, Heiko Stuebner <heiko@sntech.de>,
dianders@chromium.org, sonnyrao@chromium.org,
addy.ke@rock-chips.com, cf@rock-chips.com, wulf@rock-chips.com,
huangtao@rock-chips.com, linux-rockchip@lists.infradead.org,
Roy Li <roy.li@rock-chips.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc2: resume root hub when device detect with suspend state
Date: Mon, 17 Nov 2014 21:16:51 +0300 [thread overview]
Message-ID: <546A3B93.1030900@cogentembedded.com> (raw)
In-Reply-To: <1416230077-17535-1-git-send-email-kever.yang@rock-chips.com>
Hello.
On 11/17/2014 04:14 PM, Kever Yang wrote:
> After we implement the bus_suspend/resume, auto suspend id enabled.
> The root hub will be auto suspend if there is no device connected,
> we need to resume the root hub when a device connect detect.
> This patch tested on rk3288.
> Signed-off-by: Roy Li <roy.li@rock-chips.com>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> drivers/usb/dwc2/hcd_intr.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
> index 551ba87..c8299fd 100644
> --- a/drivers/usb/dwc2/hcd_intr.c
> +++ b/drivers/usb/dwc2/hcd_intr.c
> @@ -355,6 +355,13 @@ static void dwc2_port_intr(struct dwc2_hsotg *hsotg)
> hprt0_modify |= HPRT0_CONNDET;
>
> /*
> + * Check if root hub is in suspend state
> + * if root hub in suspend, resume it.
> + */
> + if ((bus->root_hub) && (hcd->state == HC_STATE_SUSPENDED))
Inner parens are not needed, especially the first ones.
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-11-17 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 13:14 [PATCH] usb: dwc2: resume root hub when device detect with suspend state Kever Yang
2014-11-17 15:21 ` Kever Yang
2014-11-17 18:16 ` Sergei Shtylyov [this message]
2014-11-17 21:21 ` Julius Werner
2014-11-18 1:11 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546A3B93.1030900@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=addy.ke@rock-chips.com \
--cc=balbi@ti.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dinguyen@opensource.altera.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=paulz@synopsys.com \
--cc=romain.perier@gmail.com \
--cc=roy.li@rock-chips.com \
--cc=sonnyrao@chromium.org \
--cc=wulf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox