Re: [PATCH 1/5] mfd: sec-core: Add support for S2MPS13 device

Chanwoo Choi
2014-11-18T08:33:28Z

Dear Lee,

On 11/18/2014 05:22 PM, Lee Jones wrote:
> On Mon, 17 Nov 2014, Chanwoo Choi wrote:
>
>> This patch adds the support for Samsung S2MPS13 PMIC device to the sec-core MFD
>> driver. The S2MPS13 is very similar with existing S2MPS14 and includes PMIC/
>> RTC/CLOCK devices.
>>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> drivers/mfd/sec-core.c | 18 ++++++++++++++++++
>> drivers/mfd/sec-irq.c | 23 +++++++++++++++++------
>> include/linux/mfd/samsung/core.h | 1 +
>> 3 files changed, 36 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
>> index 5993608..48c0d4a 100644
>> --- a/drivers/mfd/sec-core.c
>> +++ b/drivers/mfd/sec-core.c
>> @@ -73,6 +73,17 @@ static const struct mfd_cell s2mps11_devs[] = {
>> }
>> };
>>
>> +static const struct mfd_cell s2mps13_devs[] = {
>> + {
>> + .name = "s2mps13-pmic",
>> + }, {
>> + .name = "s2mps13-rtc",
>> + }, {
>> + .name = "s2mps13-clk",
>> + .of_compatible = "samsung,s2mps13-clk",
>> + }
>> +};
>
> If you have to resubmit this for any reason, I'd like the one liners
> on one single line (curly braces and all).

OK, I'll modify it as following:

static const struct mfd_cell s2mps13_devs[] = {
{ .name = "s2mps13-pmic", },
{ .name = "s2mps13-rtc", },
{
.name = "s2mps13-clk",
.of_compatible = "samsung,s2mps13-clk",
},
};

Best Regards,
Chanwoo Choi

>
> But for now, for my reference:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>