Re: [PATCH 4/5] rtc: s5m: Add the support for S2MPS13 RTC

Lee Jones
2014-11-18T08:25:37Z

On Tue, 18 Nov 2014, Chanwoo Choi wrote:

> Dear Sangbeom,
>
> On 11/18/2014 09:38 AM, Sangbeom Kim wrote:
> > Hi,
> > On Monday, November 17, 2014 9:43 AM, Chanwoo Choi wrote:
> >> This patch adds only the compatible string for S2MPS13 clock which is identical
> >> with S2MPS14 clock driver.
> >
> > What's the relation of S2MPS14 RTC and clock driver?
>
> I checked the difference between S2MPS13 and S2MPS14.
> But, all register (RTC) of both PMICs was the same completely.
> So, I just add S2MPS13 type to use existing S2MPS14 RTC feature for S2MPS13 RTC.

Okay, so it looks like this requires another submission. Please add
the fixup I requested in the first patch.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog