Re: [PATCH] x86: Remove Fix Mes in emulate.c from needing fault addresses

Re: [PATCH] x86: Remove Fix Mes in emulate.c from needing fault addresses

[Paolo Bonzini]

On 19/11/2014 13:48, Nicholas Krause wrote:
> Removes fix me comments for needing fault addresses to be returned in certain
> functions if they fail as they are stored and included in this file via the \
> header file,paging_tmpl.h.


    KVM: x86: Remove FIXMEs in emulate.c
    
    Remove fixme comments about needing fault addresses to be returned.  These
    are propaagated from walk_addr_generic to gva_to_gpa and from there to
    ops->read_std and ops->write_std.

> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/x86/kvm/emulate.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 9f8a2fa..f7f21d2 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2599,7 +2599,6 @@ static int task_switch_16(struct x86_emulate_ctxt *ctxt,
>  	ret = ops->read_std(ctxt, old_tss_base, &tss_seg, sizeof tss_seg,
>  			    &ctxt->exception);
>  	if (ret != X86EMUL_CONTINUE)
> -		/* FIXME: need to provide precise fault address */
>  		return ret;
>  
>  	save_state_to_tss16(ctxt, &tss_seg);
> @@ -2607,13 +2606,11 @@ static int task_switch_16(struct x86_emulate_ctxt *ctxt,
>  	ret = ops->write_std(ctxt, old_tss_base, &tss_seg, sizeof tss_seg,
>  			     &ctxt->exception);
>  	if (ret != X86EMUL_CONTINUE)
> -		/* FIXME: need to provide precise fault address */
>  		return ret;
>  
>  	ret = ops->read_std(ctxt, new_tss_base, &tss_seg, sizeof tss_seg,
>  			    &ctxt->exception);
>  	if (ret != X86EMUL_CONTINUE)
> -		/* FIXME: need to provide precise fault address */
>  		return ret;
>  
>  	if (old_tss_sel != 0xffff) {
> @@ -2624,7 +2621,6 @@ static int task_switch_16(struct x86_emulate_ctxt *ctxt,
>  				     sizeof tss_seg.prev_task_link,
>  				     &ctxt->exception);
>  		if (ret != X86EMUL_CONTINUE)
> -			/* FIXME: need to provide precise fault address */
>  			return ret;
>  	}
>  
> 

Applied, thanks.

Paolo

Re: [PATCH] x86: Remove Fix Mes in emulate.c from needing fault addresses

[Paolo Bonzini]

On 08/12/2014 04:18, nick wrote:
> Paolo,
> Not to be annoying but I am wondering, if my patch has been merged as I have yet to see it in the mainline
> kernel.

It will be sent to Linus during the merge window.

Paolo