From: Lars-Peter Clausen <lars@metafoo.de>
To: Zidan Wang <b50113@freescale.com>, broonie@kernel.org
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
ckeepax@opensource.wolfsonmicro.com, Li.Xiubo@freescale.com,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel][PATCH v2 1/2] ASoC: wm8960: Add device tree support
Date: Thu, 20 Nov 2014 09:56:34 +0100 [thread overview]
Message-ID: <546DACC2.702@metafoo.de> (raw)
In-Reply-To: <1416472878-12108-1-git-send-email-b50113@freescale.com>
On 11/20/2014 09:41 AM, Zidan Wang wrote:
[...][
> +Optional properties:
> + - shared_lrclk: This is a boolean property. If present, the LRCM bit of
> + R24 (Additional control 2 ) gets set, indicating that ADCLRC and DACLRC
> + will be disabled only when ADC (Left and Right) and DAC (Left and Right)
> + are disabled.
> +
> + - capless: This is a boolean property. If present, OUT3 will be enabled
> + and disabled together with HP_L and HP_R in response to jack detect events.
Custom properties need a vendor prefix and properties should use '-' instead
of '_'. Also the devicetree describes the hardware and not the driver, so
the description should say for which hardware setups this flag should be
set, not what the behavior of the driver will be.
- Lars
prev parent reply other threads:[~2014-11-20 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 8:41 [alsa-devel][PATCH v2 1/2] ASoC: wm8960: Add device tree support Zidan Wang
2014-11-20 8:41 ` [alsa-devel][PATCH v2 2/2] ASoC: wm8960: LRCM operation should after software reset Zidan Wang
2014-11-20 9:12 ` Charles Keepax
2014-11-20 8:56 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546DACC2.702@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b50113@freescale.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox