From: Hans Verkuil <hansverk@cisco.com>
To: Paul Bolle <pebolle@tiscali.nl>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry
Date: Mon, 24 Nov 2014 12:08:13 +0100 [thread overview]
Message-ID: <5473119D.6080205@cisco.com> (raw)
In-Reply-To: <1416826438.10073.11.camel@x220>
I found the same thing and it is already part of my pull request
to Mauro.
I'm setting this patch as Obsoleted in patchwork.
It's unclear what happened. My original patch definitely removed both
Makefile lines.
Regards,
Hans
On 11/24/14 11:53, Paul Bolle wrote:
> The deprecated omap2 camera drivers were recently removed. Both the
> Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
> directory are gone. So the Makefile entry that references both is now
> pointless. Remove it too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested by grepping the tree.
>
> Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove
> deprecated omap2 camera drivers."), which is included in next-20141124.
> What happened is that it removed only one of the two Makefile entries
> for omap24xx.
>
> drivers/staging/media/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
> index 97bfef97f838..30fb352fc4a9 100644
> --- a/drivers/staging/media/Makefile
> +++ b/drivers/staging/media/Makefile
> @@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING) += lirc/
> obj-$(CONFIG_VIDEO_DT3155) += dt3155v4l/
> obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci_vpfe/
> obj-$(CONFIG_VIDEO_OMAP4) += omap4iss/
> -obj-$(CONFIG_VIDEO_TCM825X) += omap24xx/
> obj-$(CONFIG_DVB_MN88472) += mn88472/
> obj-$(CONFIG_DVB_MN88473) += mn88473/
>
>
next prev parent reply other threads:[~2014-11-24 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 10:53 [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry Paul Bolle
2014-11-24 11:08 ` Hans Verkuil [this message]
2014-11-24 11:15 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5473119D.6080205@cisco.com \
--to=hansverk@cisco.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=pebolle@tiscali.nl \
--cc=sakari.ailus@iki.fi \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox