public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Felipe Balbi <balbi@ti.com>,
	George Cherian <george.cherian@ti.com>,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled
Date: Mon, 24 Nov 2014 21:56:28 +0100	[thread overview]
Message-ID: <54739B7C.7020102@linutronix.de> (raw)
In-Reply-To: <20141124203908.4425.qmail@stuge.se>

On 11/24/2014 09:39 PM, Peter Stuge wrote:
> Felipe Balbi wrote:
>>>> A babble only occurs when
>>>> the device side tries to move data without the host asking for anything.
>>>
>>> It also occurs if the device moves more than packet_size bytes. Not
>>> really helping, I know…
>>
>> hmm, why would the device move more than wMaxPacketSize at a time ?
> 
> Some devices are buggy.

for instance if the device comes out of resume and the clock is not yet
stable but the device sends data. That is not the case here, but an
example :)
I *think* for some reason the host did not really receive ep0
set_config request as planned. And device's answer is probably then
interpreted as data which is not expected (as Felipe said "device side
tries to move data without the host asking for anything").

>> That's certainly babble :-)
> 
> Certainly! But musb shouldn't fall over or lock up because of it, should it?

No and the patch fixes the issue. The strange thing is that it only
happens on the same device. Not if you connect host<->device with two
boards.

> //Peter
> 

Sebastian

  reply	other threads:[~2014-11-24 20:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  8:24 [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled George Cherian
2014-11-14  8:42 ` Sebastian Andrzej Siewior
2014-11-14  9:11   ` George Cherian
2014-11-14 21:02     ` Felipe Balbi
2014-11-18 21:17 ` Felipe Balbi
2014-11-19  0:44   ` Bin Liu
2014-11-19  3:12     ` Felipe Balbi
2014-11-24 17:47   ` Sebastian Andrzej Siewior
2014-11-24 17:49   ` Sebastian Andrzej Siewior
2014-11-24 18:20     ` Felipe Balbi
2014-11-24 20:39       ` Peter Stuge
2014-11-24 20:56         ` Sebastian Andrzej Siewior [this message]
2014-11-25  1:09           ` Felipe Balbi
2014-11-25  8:24             ` Sebastian Andrzej Siewior
2014-11-25 14:49               ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54739B7C.7020102@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=balbi@ti.com \
    --cc=george.cherian@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox