From: Pramod Gurav <pramod.gurav@smartplayin.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com
Subject: Re: [RFC PATCH] regulator: core: do not disable regulator if boot_on is set
Date: Tue, 25 Nov 2014 16:47:07 +0530 [thread overview]
Message-ID: <54746533.1010408@smartplayin.com> (raw)
In-Reply-To: <20141125110540.GL7712@sirena.org.uk>
Hi Mark,
On Tuesday 25 November 2014 04:35 PM, Mark Brown wrote:
> On Tue, Nov 25, 2014 at 04:23:23PM +0530, Pramod Gurav wrote:
>> Currently the regulator core disables the regulators which are unused
>> or whose reference count is zero or if they are configured always_on.
>
> No, it does *not* disable them if they are configured always_on (as the
> code you're modifying shows).
Yes, thats a typo.
>
>> This change adds a check in this logic to see if a regulator is
>> configured as boot_on and does not disable it if found true.
>
>> - if (c && c->always_on)
>> + if (c && (c->always_on || c->boot_on))
>> continue;
>
> This isn't what boot_on means. It just means that the regulator is
> expected to be enabled at initial power on, it doesn't mean it needs to
> be enabled all the time. Otherwise there'd be no point in having a
> separate always_on flag.
Thanks for the comment. :-)
>
prev parent reply other threads:[~2014-11-25 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 10:53 [RFC PATCH] regulator: core: do not disable regulator if boot_on is set Pramod Gurav
2014-11-25 10:57 ` Lucas Stach
2014-11-25 11:17 ` Pramod Gurav
2014-11-25 11:05 ` Mark Brown
2014-11-25 11:17 ` Pramod Gurav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54746533.1010408@smartplayin.com \
--to=pramod.gurav@smartplayin.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox