[PATCH] regmap: provide dummy regmap_exit()

[PATCH] regmap: provide dummy regmap_exit()

[Olof Johansson]

Fixes build error:

sound/soc/soc-core.c: In function 'snd_soc_component_exit_regmap':
sound/soc/soc-core.c:2644:2: error: implicit declaration of function 'regmap_exit' [-Werror=implicit-function-declaration]
  regmap_exit(component->regmap);

Due to the other regmap functions providing appropriate stubs when
!CONFIG_REGMAP, but this one is missing. Add it.

Signed-off-by: Olof Johansson <olof@lixom.net>
---
 include/linux/regmap.h |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index 4419b99..efb58a0 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -737,6 +737,11 @@ static inline struct regmap *dev_get_regmap(struct device *dev,
 	return NULL;
 }
 
+static inline void regmap_exit(struct regmap *map)
+{
+	return;
+}
+
 static inline struct device *regmap_get_device(struct regmap *map)
 {
 	WARN_ONCE(1, "regmap API is disabled");
-- 
1.7.10.4

Re: [PATCH] regmap: provide dummy regmap_exit()

[Lars-Peter Clausen]

On 11/25/2014 09:21 PM, Olof Johansson wrote:
> Fixes build error:
>
> sound/soc/soc-core.c: In function 'snd_soc_component_exit_regmap':
> sound/soc/soc-core.c:2644:2: error: implicit declaration of function 'regmap_exit' [-Werror=implicit-function-declaration]
>    regmap_exit(component->regmap);
>
> Due to the other regmap functions providing appropriate stubs when
> !CONFIG_REGMAP, but this one is missing. Add it.
>
> Signed-off-by: Olof Johansson <olof@lixom.net>

I did a different patch for this I was just about to send. This looks good 
as well I guess, but ...

> ---
>   include/linux/regmap.h |    5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/regmap.h b/include/linux/regmap.h
> index 4419b99..efb58a0 100644
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -737,6 +737,11 @@ static inline struct regmap *dev_get_regmap(struct device *dev,
>   	return NULL;
>   }
>
> +static inline void regmap_exit(struct regmap *map)
> +{
> +	return;

... but we really don't need the return here.

> +}
> +
>   static inline struct device *regmap_get_device(struct regmap *map)
>   {
>   	WARN_ONCE(1, "regmap API is disabled");
>

[PATCH v2] regmap: provide dummy regmap_exit()

[Olof Johansson]

Fixes build error:

sound/soc/soc-core.c: In function 'snd_soc_component_exit_regmap':
sound/soc/soc-core.c:2644:2: error: implicit declaration of function 'regmap_exit' [-Werror=implicit-function-declaration]
  regmap_exit(component->regmap);

Due to the other regmap functions providing appropriate stubs when
!CONFIG_REGMAP, but this one is missing. Add it.

Signed-off-by: Olof Johansson <olof@lixom.net>
---
 include/linux/regmap.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index 4419b99..a13e2bf 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -737,6 +737,8 @@ static inline struct regmap *dev_get_regmap(struct device *dev,
 	return NULL;
 }
 
+static inline void regmap_exit(struct regmap *map) { }
+
 static inline struct device *regmap_get_device(struct regmap *map)
 {
 	WARN_ONCE(1, "regmap API is disabled");
-- 
1.7.10.4

Re: [PATCH v2] regmap: provide dummy regmap_exit()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

On Tue, Nov 25, 2014 at 01:03:19PM -0800, Olof Johansson wrote:
> Fixes build error:
> 
> sound/soc/soc-core.c: In function 'snd_soc_component_exit_regmap':
> sound/soc/soc-core.c:2644:2: error: implicit declaration of function 'regmap_exit' [-Werror=implicit-function-declaration]
>   regmap_exit(component->regmap);

In which configuration?

> Due to the other regmap functions providing appropriate stubs when
> !CONFIG_REGMAP, but this one is missing. Add it.

Be careful on this one, you'll notice that the matching creation
functions *aren't* stubbed since there is no way to reference them
without an active dependency on regmap and indeed this use is a bit
dodgy since the core ends up freeing something that a driver allocated
which isn't ideal but probably is OK due to the general horrificness of
the AC'97 device model integration.  We only stub functions that generic
code might have a sensible reason to use in order to make it less faff
to provide generic helpers for things.  

I'll tweak the commit message when applying.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH v2] regmap: provide dummy regmap_exit()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

On Tue, Nov 25, 2014 at 09:14:31PM +0000, Mark Brown wrote:

> I'll tweak the commit message when applying.

Oh, on second thoughts Lars sent his orthogonal fix so we don't need
this for build.  Given that I'm not entirely happy with that one user
and don't really want to see others I'll skip this so we catch any other
potential users.  Makes sense?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH v2] regmap: provide dummy regmap_exit()

[Olof Johansson]

On Tue, Nov 25, 2014 at 1:14 PM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Nov 25, 2014 at 01:03:19PM -0800, Olof Johansson wrote:
>> Fixes build error:
>>
>> sound/soc/soc-core.c: In function 'snd_soc_component_exit_regmap':
>> sound/soc/soc-core.c:2644:2: error: implicit declaration of function 'regmap_exit' [-Werror=implicit-function-declaration]
>>   regmap_exit(component->regmap);
>
> In which configuration?

eseries_pxa_defconfig

>> Due to the other regmap functions providing appropriate stubs when
>> !CONFIG_REGMAP, but this one is missing. Add it.
>
> Be careful on this one, you'll notice that the matching creation
> functions *aren't* stubbed since there is no way to reference them
> without an active dependency on regmap and indeed this use is a bit
> dodgy since the core ends up freeing something that a driver allocated
> which isn't ideal but probably is OK due to the general horrificness of
> the AC'97 device model integration.  We only stub functions that generic
> code might have a sensible reason to use in order to make it less faff
> to provide generic helpers for things.
>
> I'll tweak the commit message when applying.

Based on the other reply, you went with ifdefs in the audio code
instead, which is ok with me.


-Olof