From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932255AbcBEOP7 (ORCPT ); Fri, 5 Feb 2016 09:15:59 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:49189 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932207AbcBEOPq (ORCPT ); Fri, 5 Feb 2016 09:15:46 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Sekhar Nori , Kevin Hilman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] ARM: davinci: make I2C support optional Date: Fri, 05 Feb 2016 15:15:16 +0100 Message-ID: <5475182.6SLDQGvbZt@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56B4A19D.4060307@ti.com> References: <1454358962-640598-1-git-send-email-arnd@arndb.de> <1454358962-640598-5-git-send-email-arnd@arndb.de> <56B4A19D.4060307@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:t9KA99Nx0ClpJY02qAywMhXmxwa2eAd9vYD7DnR5To9zVRGbHEB Z5WojCCJzUG33JjGhDNFzppBMJrGQfuwRQxovQKySa42dyESQ2aiQqG0ANRGlwI5vN08JjO YISENxAvh79H/BRD/zfY8Ly5bJdMehUiH+Gd6p1AEXKKjzoUHldwTDulXt1zlxccx2sQFwb 6tYXfPnfpqqHSI43KYc3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:O/s5zGoS06s=:UwPQN4887RMVzx9Z3/piHi AaGcukJQDpWgGb4/OrRnWMRCi0RDz62w5MooV6yWxIKP72uHowQ11NCnybrFH6YxhoLuRyHZx ih6BwYOGH7JNWwRToI8FbrmYl5W5cX7ROz5gIb2E9dy12vylAksb7STCXABwmjNQGMnhO+vH6 oXqGjtV4baCImgPNrNE+wOvcjt7lXk+0uykPw78LDUdWXPydT1ea64tdhbNhEVUqZIURXgEhH dWrRErxonJ9ChQjUXaFUsr0EF6hpqD0Ppg5HnMgbP6t7mukM9HyC2NKnCwMyVgWEZViaRtfF8 6ErgFuLAnUXTWJH+DEX9FtAEkAefC9TGdUiklrx8ZF2DiDLuM7Q8mM09UqW4hCboJRHLtC6r6 wAB3liRUvjLxDYzEc8os3mgGMZx5sWgybpeufDixoICOu9dV+ANQlwJ7sB0nCfLijS/NIsgas eIhkdQZe7ZHzBBk5E9CWCRZaXxxr/wRIgWvyyfHJH/zwwQYOPJ9eujI9Top4QG8eeFs7wpV3e xQl9vq5t9vlDEh4rz4xiDRnvKD9n99OWa0gMSdA/4EoURiVjE238m1al8M3ffTt+l2N381vd1 UfGFxBHPltNvOvI0mtZ5KLHjHMw9/HC9aEP8730swQVf9Crb9dq1G4GqEKzC1PNBOg4jmDuRX vlU0qDD6fbTR77YT/0KtZJaosYIWkgRXIojdL6OtVawELqanPkSgKZvCK04kX4PRnd54kcBeb rXZ732d0T8YI72+H Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 05 February 2016 18:50:29 Sekhar Nori wrote: > > I checked that CONFIG_I2C is still enabled with davinci_all_defconfig, > > so that does not have to change. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 45b146d746ea ("ARM: Davinci: Fix I2C build errors") > > Fixes: 22ca466847ad ("davinci: kconfig: select at24 eeprom for selected boards") > > This looks good to me. The #ifdefs in the middle of davinci_evm_init() > are an eyesore, but getting rid of the selects is a big plus. > I agree on the eyesore. I had an earlier version using "if (IS_BUILTIN(CONFIG_I2C))" checks that was much nicer, but it didn't work because all the declarations in include/linux/i2c.h are hidden behind an #ifdef. I thought about sending a patch for that file too, but I think it has come up before and was nacked then. Arnd