* [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf
@ 2014-07-08 12:03 Bartlomiej Zolnierkiewicz
2014-11-26 7:52 ` Pankaj Dubey
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-07-08 12:03 UTC (permalink / raw)
To: Kukjin Kim
Cc: Kyungmin Park, linux-samsung-soc, linux-arm-kernel, linux-kernel
Values stored in val[] are never bigger than a byte.
text data bss dec hex filename
5264 4 4 5272 1498 arch/arm/mach-exynos/pmu.o.before
2992 4 4 3000 bb8 arch/arm/mach-exynos/pmu.o.after
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/mach-exynos/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index b850db4..55ff019 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -101,7 +101,7 @@ enum sys_powerdown {
struct exynos_pmu_conf {
void __iomem *reg;
- unsigned int val[NUM_SYS_POWERDOWN];
+ u8 val[NUM_SYS_POWERDOWN];
};
extern void exynos_sys_powerdown_conf(enum sys_powerdown mode);
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf
2014-07-08 12:03 [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf Bartlomiej Zolnierkiewicz
@ 2014-11-26 7:52 ` Pankaj Dubey
0 siblings, 0 replies; 2+ messages in thread
From: Pankaj Dubey @ 2014-11-26 7:52 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Kukjin Kim
Cc: Kyungmin Park, linux-samsung-soc, linux-arm-kernel, linux-kernel
Hi Bartilomiej,
On Tuesday 08 July 2014 05:33 PM, Bartlomiej Zolnierkiewicz wrote:
> Values stored in val[] are never bigger than a byte.
>
> text data bss dec hex filename
> 5264 4 4 5272 1498 arch/arm/mach-exynos/pmu.o.before
> 2992 4 4 3000 bb8 arch/arm/mach-exynos/pmu.o.after
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
I tested this patch and it's really helpful to reduce size.
How about resubmitting this change? As this will not get applied on
current tree.
Thanks,
Pankaj Dubey
> ---
> arch/arm/mach-exynos/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index b850db4..55ff019 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -101,7 +101,7 @@ enum sys_powerdown {
>
> struct exynos_pmu_conf {
> void __iomem *reg;
> - unsigned int val[NUM_SYS_POWERDOWN];
> + u8 val[NUM_SYS_POWERDOWN];
> };
>
> extern void exynos_sys_powerdown_conf(enum sys_powerdown mode);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-26 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-08 12:03 [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf Bartlomiej Zolnierkiewicz
2014-11-26 7:52 ` Pankaj Dubey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox