Re: Re: [PATCH ftrace/core v6 5/5] kselftest, ftrace: Add ftrace IPMODIFY flag test

Masami Hiramatsu
2014-11-26T07:20:15Z

(2014/11/25 23:44), Shuah Khan wrote:
> On 11/25/2014 07:42 AM, Shuah Khan wrote:
>> On 11/24/2014 06:23 PM, Masami Hiramatsu wrote:
>>> (2014/11/25 1:18), Shuah Khan wrote:
>>>> On 11/24/2014 07:11 AM, Masami Hiramatsu wrote:
>>>>> (CC'ed Shuah, since this is related to kselftest)
>>>>>
>>>>>
>>>>> So, if your server directory is mounted with noexec, it's an environmental
>>>>> problem. I guess you can not build any kernel drivers on that testbox, can you?
>>>>>
>>>>> Anyway, this gives us a good question, "should test binaries be made by
>>>>> server or client(testbox) environment?" This ipmodify driver is a binary
>>>>> and it should be built with the kernel binary (by server) I think.
>>>>> But yes, I missed the Makefile didn't allow that (this always referred
>>>>> installed running kernel builddir).
>>>>>
>>>>> I hope to have CONFIG_KSELFTEST_BINARIES for Kconfig, or make prep_kselftest
>>>>> target to build these binaries with kernel...
>>>>>
>>>>> Shuah, what would you think about this?
>>>>
>>>> I am working on patch series to add an install target to the
>>>> main kernel makefile, so these tests can be built and installed
>>>> on a target just like we do with kernel and modules. I hope to
>>>> get this in 3.19 or definitely into 3.20
>>>>
>>>> This probably will help address the problem you are seeing.
>>>> Install target is needed for qemu type environments as well.
>>>
>>> Yes, that is what we need for this test case!
>>> Please CC to me when sending the series. I'd like to try and
>>> know how it works :)
>>>
>>
>> Good. Please take a look at this thread and give it a try. Please
>> give me feedback as well. This is the first step to get the install
>> feature added and then we can refine it at the selftests level as
>> needed.
>>
>> https://lkml.org/lkml/2014/11/11/851

OK, I'll try that.
BTW, are those patches included in the below kernel.org tree ?

https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git/

> Forgot to mention I didn't include ftrace in this first series for
> install, planning to add it in my next round of patches. I have the
> code ready for to do that.

No problem, I'll wait for your series :)

Thank you,

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com