From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755055AbcIANEC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 09:04:02 -0400
Received: from mailout4.samsung.com ([203.254.224.34]:35457 "EHLO
        mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754720AbcIAND6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 09:03:58 -0400
X-AuditID: cbfee61b-f79466d000001e3c-cc-57c8273bb223
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Randy Li <ayaka@soulik.info>
Cc: devicetree@vger.kernel.org, mark.rutland@arm.com,
        linux@armlinux.org.uk, kgene@kernel.org, krzk@kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        robh@kernel.org
Subject: Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP
 package version
Date: Thu, 01 Sep 2016 15:03:51 +0200
Message-id: <5477278.USWYFxDPfA@amdc1976>
User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <1472648307-3818-1-git-send-email-ayaka@soulik.info>
References: <a35686c3-294b-a16a-2b0e-0ef2fd460244@kernel.org>
 <1472648307-3818-1-git-send-email-ayaka@soulik.info>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsVy+t9jAV1r9RPhBh2vDSxe3f3FaDH/yDlW
        i/7Hr5ktzp/fwG6x6fE1VovLu+awWcw4v4/J4tDUvYwWS69fZLL4v2cHuwOXx5p5axg9Ll+7
        yOyxaVUnm8fmJfUezXens3p83iQXwBbFZZOSmpNZllqkb5fAlXH191r2gnNcFT3f37M1MG7n
        6GLk4JAQMJGYc7m4i5ETyBSTuHBvPVsXIxeHkMBSRomlR6YxQzhfGSVOLtnIAlLFJmAlMbF9
        FSOILSKgILF8wXYmkCJmgTeMEj9v7mIFSQgLREn0rHrEDGKzCKhKvFv6H6yBV0BTYuH6zWBx
        UQEviZ7tj8DinAKOEp+P9jGDXCQkUCIxvVMPolxQ4sfke2B7mQXkJfbtn8oKYWtJrN95nGkC
        o8AsJGWzkJTNQlK2gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZwRDyT3sF4eJf7
        IUYBDkYlHt4ZlsfDhVgTy4orcw8xSnAwK4nwHpM/ES7Em5JYWZValB9fVJqTWnyIUZqDRUmc
        9/H/dWFCAumJJanZqakFqUUwWSYOTqkGRjOGi1OnRR1uMp4wJ2/VVHaBCdLXudP26HyVzbbz
        sLyh3Fu87rp5Sv/dXN8zRj6yP+Xvn3347hFT5U2D5PLs7y6HDog//TaPI+wWv8epfo/S2LsF
        hmw3bZkEWGVqmiJe/DFb0l/0d9f0S7dm7r91rdfj8aGS1MBSvU3yMTIzL968/+z2mnmyc5RY
        ijMSDbWYi4oTAd4CJF2EAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

On Wednesday, August 31, 2016 08:58:27 PM Randy Li wrote:
> The TOPEET itop is a samsung exnynos 4412 core board, which have
> two package versions. This patch add the support for SCP version.
> 
> Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and
> PMIC. The future features are in the based board. Also MFC and
> watchdog have been enabled.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi | 490 ++++++++++++++++++++++++
>  1 file changed, 490 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi

[...]

> +		s5m8767_osc: clocks {

Don't you also need:

			compatible = "samsung,s5m8767-clk";

here?

BTW Does anyone know why there are no users of
"samsung,s2mps11-clk" compatible in the tree
(commit 53c31b3437a6400c6ffc2c9315680217ad84cb6d
"mfd: sec-core: Add of_compatible strings for
clock MFD cells" added it in March 2014)?

> +			#clock-cells = <1>;
> +			clock-output-names = "s5m8767_ap",
> +					"s5m8767_cp", "s5m8767_bt";
> +		};
> +
> +	};
> +};

[...]

> +&rtc {
> +	status = "okay";
> +	clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>;
> +	clock-names = "rtc", "rtc_src";
> +};

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics